feat: implemented the dev card OG image #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nickytonline
force-pushed
the
nickytonline/og-image-dev-card
branch
6 times, most recently
from
0fd30c9 to
ccdd4fb
Compare
nickytonline
force-pushed
the
nickytonline/og-image-dev-card
branch
from
17817e2 to
bc2a180
Compare
nickytonline
commented
Aug 9, 2024
nickytonline
force-pushed
the
nickytonline/og-image-dev-card
branch
from
bc2a180 to
8475050
Compare
nickytonline
force-pushed
the
nickytonline/og-image-dev-card
branch
from
8806d51 to
b1e1e20
Compare
jpmcb
approved these changes
Aug 9, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [2.53.0-beta.2](v2.53.0-beta.1...v2.53.0-beta.2) (2024-08-09) ### 🍕 Features * implemented the dev card OG image ([#3903](#3903)) ([5047e1f](5047e1f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the dev card OG image including the new OSCR score. This is the OG image for the dev card and user profile pages now.
@isabensusan, I was unable to use linear gradient for the border on the top % section as well as on the icons. We can revisit that when you're back.
Stating the obvious, but this generates an image, so accessibility in the JSX used to generate the image is irrelevant as it's no longer markup that's generated.
Related Tickets & Documents
Closes #3760
Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?