Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve layout design for large screens #1231 #1437

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix: improve layout design for large screens #1231 #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/molecules/RepoRow/repo-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,14 @@ const RepoRow = ({ repo, topic, userPage, selected, handleOnSelectRepo }: RepoPr
</div>

{/* Column: Contributors */}
<div className={clsx(classNames.cols.contributors, "hidden lg:flex")}>
<div className={clsx(classNames.cols.contributors, "hidden xl:flex")}>
{contributorData.length! > 0 ? <StackedAvatar contributors={contributorData} /> : "-"}

{contributorData.length! > 5 ? <div>&nbsp;{`+${contributorData.length - 5}`}</div> : ""}
</div>

{/* Column: Last 30 Days */}
<div className={clsx(classNames.cols.last30days, "hidden lg:flex")}>
<div className={clsx(classNames.cols.last30days, "hidden xl:flex")}>
{repo.id && last30days ? <Sparkline data={last30days} /> : "-"}
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions components/organisms/Repositories/repositories.tsx
View file
Open in desktop
OgDev-01 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const Repositories = ({ repositories }: RepositoriesProps): JSX.Element => {
title="Repositories"
/>
<div className="flex flex-col w-full overflow-x-auto border rounded-lg">
<div className="lg:min-w-[1150px]">
<div>
<div className="flex justify-between gap-2 px-6 py-4 md:hidden bg-light-slate-3">
<div className="flex-1">
<TableTitle> Repository </TableTitle>
Expand Down Expand Up @@ -133,10 +133,10 @@ const Repositories = ({ repositories }: RepositoriesProps): JSX.Element => {
<div className={clsx(classNames.cols.spam)}>
<TableTitle>SPAM</TableTitle>
</div>
<div className={clsx(classNames.cols.contributors, "hidden lg:flex")}>
<div className={clsx(classNames.cols.contributors, "hidden xl:flex")}>
<TableTitle>Contributors</TableTitle>
</div>
<div className={clsx(classNames.cols.last30days, "hidden lg:flex")}>
<div className={clsx(classNames.cols.last30days, "hidden xl:flex")}>
<TableTitle>Last 30 Days</TableTitle>
</div>
</div>
Expand Down