-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: loading dev card page from the user profile crashes #4108
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue. For full info on how to contribute, please check out our contributors guide. |
This is still an issue, but it appears to only occur when running locally in dev mode. Beta and Prod are fine. Also running It should be sorted out still though as this make for poor DX if working on the user profile/dev card. The odd thing is this is a server-side prop so if it's set, which it does get set, it shouldn't be undefined when running client-side during hydration. app/pages/u/[username]/card.tsx Lines 39 to 55 in cc7f172
|
@nickytonline what do you want to do with this? should this still be debugged? |
It's, most likely related to React's strict mode which is on by default in Next.js. Feel free to dig into this. |
Got it💪🏽 |
Can I work on this? |
Please read the contributing guidelines if you'd like to work on this. |
.take |
Thanks |
Hello @nickytonline Note: I have followed the steps |
@Bashamega, ensure you have latest of the beta branch. I just pulled down all the latest changes and I do not get the error you get, I get the original error still. |
@nickytonline on my side the profile page is not loading, so i can't click on the badge. |
Please ensure that you have the latest of the beta branch and that you've followed the steps in our README to get up and running locally. It definitely works locally (with the error mentioned in the issue) and it's working in our beta and production environment, so my guess is there is something not right in your local environment. |
I have followed the steps in the readme.
|
sure |
Thanks @nickytonline , |
The problem is with the Link tag, the link tag doesn't make it a full reload, causing the
|
Glad things work for your environment now. We want to keep the getServerSideProps, but I'm not sure a window.location.href is the best option as this only happens in development mode. Put up a pull request and we can continue the conversation there. |
The issue with Locally, this could be caused by differences in how environments handle data prefetching and cache control, or it might relate to how Next.js manages client-side navigation. In production, server configurations and CDN setups might handle these differently, which is why it works there but not locally. |
sure |
…d of link tags fixed the bug by using a tags instead of link tags fix open-sauced#4108
🎉 This issue has been resolved in version 2.64.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.64.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Going to the dev card page directly works, but if you click on the dev card button near the avatar on the user profile page, it crashes.
The
user
isnull
causing the crash.The text was updated successfully, but these errors were encountered: