Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: setup cypress e2e tests #239

Closed
wants to merge 4 commits into from
Closed

test: setup cypress e2e tests #239

wants to merge 4 commits into from

Conversation

diivi
Copy link
Contributor

@diivi diivi commented Aug 4, 2023

Description

#238

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#238

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@diivi
Copy link
Contributor Author

diivi commented Aug 4, 2023

@Anush008
Copy link
Member

Anush008 commented Aug 4, 2023

Should I run the build job before the test job?

That seems to be the reason why the e2e test has failed. Because its unable to find the extension build.

We should probably run vitest first, followed by a build and then the e2e tests.

@diivi
Copy link
Contributor Author

diivi commented Aug 4, 2023

We should probably run vitest first, followed by a build and then the e2e tests.

That's not possible with the current workflow setup (it just runs npm run test), so I'll move build up.

@nickytonline
Copy link
Member

We should probably run vitest first, followed by a build and then the e2e tests.

That's not possible with the current workflow setup (it just runs npm run test), so I'll move build up.

Before you go further with Cypress @diivi, I left a comment about investigating Playwright instead. See #238 (comment)

@bdougie
Copy link
Member

bdougie commented Sep 1, 2023

@bdougie bdougie closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants