fix: redirect to home page after posting a highlight #203

marcusgchan · 2023-07-11T18:02:16Z

What type of PR is this? (check all applicable)

Description

This PR redirects the users to the home page after creating a highlight.

Related Tickets & Documents

Fixes #178

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions

PR Compliance Checks Passed!

marcusgchan · 2023-07-19T19:26:11Z

One thing i noticed is the highlights aren't updated immediately on the home page of the extension because I think it's cached. Is there a function i can call to invalidate or update the cache?

marcusgchan · 2023-07-19T19:27:33Z

Or do you think it's fine to let it update once it expires

Anush008 · 2023-07-19T19:37:02Z

You are correct. The highlights are cached for 300 seconds.

ai/src/popup/pages/home.tsx

Lines 37 to 40 in 311f456

    
           useEffect(() => { 
        
               const fetchHighlights = async () => { 
        
                   try { 
        
                       const userHighlightsData = await getHighlights();

ai/src/utils/fetchOpenSaucedApiData.ts

Lines 174 to 187 in 311f456

    
           export const getHighlights = async (): Promise<Highlights | undefined> => { 
        
               const response = await cachedFetch( 
        
                   `${OPEN_SAUCED_HIGHLIGHTS_LIST_ENDPOINT}?limit=10`, 
        
                   { 
        
                       method: "GET", 
        
                       expireInSeconds: 300, 
        
                   }, 
        
               ); 
        
               if (!response) { 
        
                   return; 
        
               } 
        
               return response.json(); 
        
           };

The cachedFetch() can accepts a forceRefresh bool to invalidate the cache.

Anush008 · 2023-07-19T19:40:50Z

We can parameterize the Home component with a forceRefresh value, defaulting to false, that can be passed when navigating to it. Like so

ai/src/popup/pages/home.tsx

Line 112 in 311f456

goTo(Profile, { username: user.user_name });

The value will govern whether to do a force refresh when getting the highlights. The getHighlights() will need an update for the forceRefresh argument.

marcusgchan · 2023-07-19T20:58:11Z

Thanks for the detailed overview!

Anush008

Great. Thanks for working on this @marcusgchan.

## [1.12.0-beta.3](v1.12.0-beta.2...v1.12.0-beta.3) (2023-07-20) ### 🐛 Bug Fixes * redirect to home page after posting a highlight ([#203](#203)) ([4ebd2d1](4ebd2d1))

github-actions · 2023-07-20T15:50:33Z

🎉 This PR is included in version 1.12.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.12.0-beta.3](open-sauced/ai@v1.12.0-beta.2...v1.12.0-beta.3) (2023-07-20) ### 🐛 Bug Fixes * redirect to home page after posting a highlight ([#203](open-sauced/ai#203)) ([4ebd2d1](open-sauced/ai@4ebd2d1))

* feat: view repos on opensauced (#218) * feat: view repos on opensauced * change var names * chore(minor): release 1.12.0-beta.1 on beta channel [skip ci] ## [1.12.0-beta.1](v1.11.1...v1.12.0-beta.1) (2023-07-18) ### 🍕 Features * view repos on opensauced ([#218](#218)) ([f33d9fd](f33d9fd)) * fix: post highlights from the extension (#223) * chore(patch): release 1.12.0-beta.2 on beta channel [skip ci] ## [1.12.0-beta.2](v1.12.0-beta.1...v1.12.0-beta.2) (2023-07-19) ### 🐛 Bug Fixes * post highlights from the extension ([#223](#223)) ([7d91011](7d91011)) * fix: redirect to home page after posting a highlight (#203) * fix: redirect to home page after posting a highligh * Added forceRefresh param to force cache invalidation * chore: default val forceRefresh, typo --------- Co-authored-by: Anush008 <[email protected]> * chore(patch): release 1.12.0-beta.3 on beta channel [skip ci] ## [1.12.0-beta.3](v1.12.0-beta.2...v1.12.0-beta.3) (2023-07-20) ### 🐛 Bug Fixes * redirect to home page after posting a highlight ([#203](#203)) ([4ebd2d1](4ebd2d1)) * fix: view on open sauced location (#225) * bug-fix: view on open sauced location * fix: change classname to constant name * fix: remove unwanted lint changes in constants * feat: change variable name * fix: remove element cast Co-authored-by: Nick Taylor <[email protected]> --------- Co-authored-by: Nick Taylor <[email protected]> * chore(patch): release 1.12.0-beta.4 on beta channel [skip ci] ## [1.12.0-beta.4](v1.12.0-beta.3...v1.12.0-beta.4) (2023-07-25) ### 🐛 Bug Fixes * view on open sauced location ([#225](#225)) ([0ecfef0](0ecfef0)) * feat: Login with pkce (#230) * chore(minor): release 1.12.0-beta.5 on beta channel [skip ci] ## [1.12.0-beta.5](v1.12.0-beta.4...v1.12.0-beta.5) (2023-07-28) ### 🍕 Features * Login with pkce ([#230](#230)) ([42e8d4a](42e8d4a)) --------- Co-authored-by: Divyansh Singh <[email protected]> Co-authored-by: Marcus Chan <[email protected]> Co-authored-by: Anush008 <[email protected]> Co-authored-by: Pratham <[email protected]> Co-authored-by: Nick Taylor <[email protected]>

## [1.12.0](v1.11.1...v1.12.0) (2023-07-31) ### 🍕 Features * Login with pkce ([#230](#230)) ([42e8d4a](42e8d4a)) * view repos on opensauced ([#218](#218)) ([f33d9fd](f33d9fd)) ### 🐛 Bug Fixes * manual release.yml ([a41de3f](a41de3f)) * post highlights from the extension ([#223](#223)) ([7d91011](7d91011)) * redirect to home page after posting a highlight ([#203](#203)) ([4ebd2d1](4ebd2d1)) * view on open sauced location ([#225](#225)) ([0ecfef0](0ecfef0))

github-actions · 2023-07-31T05:21:24Z

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

marcusgchan changed the title ~~fix: redirect to home page after posting a highligh~~ fix: redirect to home page after posting a highlight Jul 11, 2023

github-actions bot reviewed Jul 11, 2023

View reviewed changes

marcusgchan force-pushed the fix/redirect-to-home-after-posting-highlight branch from d348f6d to f0a5060 Compare July 17, 2023 21:18

fix: redirect to home page after posting a highligh

b71005c

marcusgchan force-pushed the fix/redirect-to-home-after-posting-highlight branch from f0a5060 to b71005c Compare July 19, 2023 19:00

Added forceRefresh param to force cache invalidation

d503384

marcusgchan marked this pull request as ready for review July 19, 2023 20:59

chore: default val forceRefresh, typo

b3842d2

Anush008 approved these changes Jul 20, 2023

View reviewed changes

diivi approved these changes Jul 20, 2023

View reviewed changes

bdougie merged commit 4ebd2d1 into open-sauced:beta Jul 20, 2023

github-actions bot added the released on @beta label Jul 20, 2023

bdougie mentioned this pull request Jul 31, 2023

main <- v1.12.0-beta.5 #232

Merged

github-actions bot added the released label Jul 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: redirect to home page after posting a highlight #203

fix: redirect to home page after posting a highlight #203

marcusgchan commented Jul 11, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

marcusgchan commented Jul 19, 2023 •

edited

Loading

marcusgchan commented Jul 19, 2023

Anush008 commented Jul 19, 2023

Anush008 commented Jul 19, 2023 •

edited

Loading

marcusgchan commented Jul 19, 2023

Anush008 left a comment

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 31, 2023

fix: redirect to home page after posting a highlight #203

fix: redirect to home page after posting a highlight #203

Conversation

marcusgchan commented Jul 11, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

marcusgchan commented Jul 19, 2023 • edited Loading

marcusgchan commented Jul 19, 2023

Anush008 commented Jul 19, 2023

Anush008 commented Jul 19, 2023 • edited Loading

marcusgchan commented Jul 19, 2023

Anush008 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 31, 2023

marcusgchan commented Jul 11, 2023 •

edited

Loading

github-actions bot left a comment •

edited

Loading

marcusgchan commented Jul 19, 2023 •

edited

Loading

Anush008 commented Jul 19, 2023 •

edited

Loading