fix: Made the "Tools:" conditional according to the current page #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submitting for review
Co-authored-by: Brian Douglas <[email protected]>
Co-authored-by: Brian Douglas <[email protected]>
Co-authored-by: Brian Douglas <[email protected]>
Co-authored-by: Brian Douglas <[email protected]>
Co-authored-by: Brian Douglas <[email protected]>
Co-authored-by: Brian Douglas <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "beta" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.
punyamsingh
changed the title
Anush008
suggested changes
Jun 25, 2023
There was a problem hiding this comment.
Hey @punyamsingh. This works. I've suggested a change for you to consider and to hear your thoughts about it.
Anush008
reviewed
Jun 25, 2023
|
@Anush008 i have made the requested changes |
Anush008
approved these changes
Jun 26, 2023
bdougie
reviewed
Jun 27, 2023
bdougie
approved these changes
Jun 28, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
## [1.9.0-beta.3](v1.9.0-beta.2...v1.9.0-beta.3) (2023-06-29) ### 🐛 Bug Fixes * Made the "Tools:" conditional according to the current page ([#197](#197)) ([b08ad07](b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)
|
🎉 This PR is included in version 1.9.0-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
## [1.9.0](v1.8.0...v1.9.0) (2023-06-29) ### ✅ Tests * Tests for colorPreference and getUserPRVelocity ([#190](#190)) ([6b9a5c3](6b9a5c3)) ### 🍕 Features * post to linkedin projects ([#177](#177)) ([a20bff4](a20bff4)) ### 🐛 Bug Fixes * Made the "Tools:" conditional according to the current page ([#197](#197)) ([b08ad07](b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112) * separate vite and vitest configs ([#193](#193)) ([7a980c8](7a980c8))
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
zer0and1
pushed a commit
to zer0and1/open-sauced.ai
that referenced
this pull request
Jul 26, 2023
## [1.9.0-beta.3](open-sauced/ai@v1.9.0-beta.2...v1.9.0-beta.3) (2023-06-29) ### 🐛 Bug Fixes * Made the "Tools:" conditional according to the current page ([#197](open-sauced/ai#197)) ([b08ad07](open-sauced/ai@b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)
zer0and1
pushed a commit
to zer0and1/open-sauced.ai
that referenced
this pull request
Jul 26, 2023
## [1.9.0](open-sauced/ai@v1.8.0...v1.9.0) (2023-06-29) ### ✅ Tests * Tests for colorPreference and getUserPRVelocity ([#190](open-sauced/ai#190)) ([6b9a5c3](open-sauced/ai@6b9a5c3)) ### 🍕 Features * post to linkedin projects ([#177](open-sauced/ai#177)) ([a20bff4](open-sauced/ai@a20bff4)) ### 🐛 Bug Fixes * Made the "Tools:" conditional according to the current page ([#197](open-sauced/ai#197)) ([b08ad07](open-sauced/ai@b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112) * separate vite and vitest configs ([#193](open-sauced/ai#193)) ([7a980c8](open-sauced/ai@7a980c8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
the "Tools:" option is no longer visible when the current page is not a PR/Repo/User.
as mentioned in issue #196
Added a const variable renderToolsConditions that checks if the conditions are right to show the "Tools:"
if even one condition is present, it is displayed, or else it doesn't.
we can add more conditions in this variable if necessary in the future.
I have only made changes to home.tsx file. rest are unchanged.
Related Tickets & Documents
Fixes #196
Mobile & Desktop Screenshots/Recordings
visible on PR page
visible on github profile page
visible on repo page
not visible on unknown pages (eg:- StackOverflow)
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?