chore: add a user feedback in case of an error #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feedback would show the user a message if something went wrong while generating AI for post to highlight
bdougie
changed the title
|
Can you add a screenshot @a0m0rajab? |
|
@bdougie added. |
|
where does "Configuration file is empty" come from? Doesn't seem like a helpful error. |
|
@diivi from this line: I manually through it to get the error screenshot. |
Anush008
approved these changes
Jun 10, 2023
|
Not so sure about "file", but it was there before too, so okay! |
|
The copy might need an update but that's out of scope of this PR, you can check the code.
Sent from mobile device
…________________________________
From: Divyansh Singh ***@***.***>
Sent: Sunday, June 11, 2023 12:20:33 AM
To: open-sauced/ai ***@***.***>
Cc: Abdurrahman Rajab ***@***.***>; Mention ***@***.***>
Subject: Re: [open-sauced/ai] chore: add a user feedback in case of an error (PR #171)
https://github.com/open-sauced/ai/blob/8ce37248bbd71cef152919d3e6585f5cf5c4bc8f/src/content-scripts/components/GenerateAIDescription/DescriptionGeneratorButton.ts#L73
Not so sure about "file", but it was there before too, so okay!
—
Reply to this email directly, view it on GitHub<#171 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AELNMKPSFSLDQVWBOVZFNL3XKTQKDANCNFSM6AAAAAAY4CYVNU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Merged
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a toast promise to the generateAiDescription function in posthighlight.tsx. The toast promise displays a loading message wThis feedback would show the user a message if something went wrong while generating AI for post to highlight
This adds an error message feedback for user when they face an issue in the AI generation on the post to highight popup
What type of PR is this? (check all applicable)
Description
This adds an error message feedback for user when they face an issue in the AI generation on the post to highight popup
Related Tickets & Documents
#168
Mobile & Desktop Screenshots/Recordings
While Generating:
Successful message:
Error Message:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?