refactor: removed post highlight message passing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jun 4, 2023
## [1.4.1-beta.3](v1.4.1-beta.2...v1.4.1-beta.3) (2023-06-04) ### 🧑💻 Code Refactoring * removed post highlight message passing ([#165](#165)) ([bad2112](bad2112))
|
🎉 This PR is included in version 1.4.1-beta.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
## [1.5.0](v1.4.0...v1.5.0) (2023-06-06) ### 🧑💻 Code Refactoring * removed post highlight message passing ([#165](#165)) ([bad2112](bad2112)) ### 🍕 Features * extension settings ([#132](#132)) ([722cbbe](722cbbe)) ### 🐛 Bug Fixes * highlight redirection, multiple AI generation, draft commit messages ([#163](#163)) ([03b91ab](03b91ab)) * post-highlight-page-check ([#164](#164)) ([ed98eb2](ed98eb2)) * remove configuration enabled check from AI button ([#170](#170)) ([cedca79](cedca79))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
zer0and1
added a commit
to zer0and1/open-sauced.ai
that referenced
this pull request
Jul 26, 2023
## [1.4.1-beta.3](open-sauced/ai@v1.4.1-beta.2...v1.4.1-beta.3) (2023-06-04) ### 🧑💻 Code Refactoring * removed post highlight message passing ([#165](open-sauced/ai#165)) ([bad2112](open-sauced/ai@bad2112))
zer0and1
pushed a commit
to zer0and1/open-sauced.ai
that referenced
this pull request
Jul 26, 2023
## [1.5.0](open-sauced/ai@v1.4.0...v1.5.0) (2023-06-06) ### 🧑💻 Code Refactoring * removed post highlight message passing ([#165](open-sauced/ai#165)) ([bad2112](open-sauced/ai@bad2112)) ### 🍕 Features * extension settings ([#132](open-sauced/ai#132)) ([722cbbe](open-sauced/ai@722cbbe)) ### 🐛 Bug Fixes * highlight redirection, multiple AI generation, draft commit messages ([#163](open-sauced/ai#163)) ([03b91ab](open-sauced/ai@03b91ab)) * post-highlight-page-check ([#164](open-sauced/ai#164)) ([ed98eb2](open-sauced/ai@ed98eb2)) * remove configuration enabled check from AI button ([#170](open-sauced/ai#170)) ([cedca79](open-sauced/ai@cedca79))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR includes refactoring of the post highlight feature to remove message passing, removal of message listener from github.ts, and addition of tests for getPullRequestAPIURL() function. These changes improve the code quality and ensure better test coverage.
Generated using OpenSauced.
As mentioned before, message passing to a content-script is error-prone and should be avoided if possible.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?