test: Tests for colorPreference and getUserPRVelocity

[TheLazron]

What type of PR is this? (check all applicable)

•  🍕 Feature
•  🐛 Bug Fix
•  📝 Documentation Update
•  🎨 Style
•  🧑‍💻 Code Refactor
•  🔥 Performance Improvements
•  ✅ Test
•  🤖 Build
•  🔁 CI
•  📦 Chore (Release)
•  ⏩ Revert

Description

This PR is related to Write tests for utility functions #188 and adds tests for the following files:

• src/utils/colorPreference.ts
• src/utils/getUserPRVelocity.ts

In order to work with window object, modifications were made to the Vite config, setting the environment to 'jsdom',
No other files or tests were changed or affected.

Related Tickets & Documents

[#188]

Mobile & Desktop Screenshots/Recordings

Added tests?

•  👍 yes
•  🙅 no, because they aren't needed
•  🙋 no, because I need help

Added to documentation?

•  📜 README.md
•  📓 docs.opensauced.pizza
•  🍕 dev.to/opensauced
•  📕 storybook
•  🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

[Anush008]

Thank you for this. 👍👍

[TheLazron]

The failing test is passing in my local dev environment.

[Anush008]

The failing test is passing in my local dev environment.

Same with me.
@diivi can you try running the tests on your machine?

[diivi]

Weird 😕, can you try changing the test just a bit so the value changes to something else? It passes for me too.

[TheLazron]

Sure, will revert back

[Anush008]

This could be due to the varying timezone of the test runner. The new Date() constructor uses the local timezone by default.
https://github.com/TheLazron/ai/blob/2296205cede6ecd77c1dfb4b6356f42d1e9f5ca8/src/utils/getUserPRVelocity.ts#L8-L13

Edit: This shouldn't be a problem since we're getting the difference in days of 2 dates of the same timezone.

[TheLazron]

This could be due to the varying timezone of the test runner. The new Date() constructor uses the local timezone by default. https://github.com/TheLazron/ai/blob/2296205cede6ecd77c1dfb4b6356f42d1e9f5ca8/src/utils/getUserPRVelocity.ts#L8-L13

So should I try changing the time zone in the tests?

[Anush008]

So should I try changing the time in the tests?

Can you try using Math.floor()here and pushing the commit to rerun the tests with the change?
https://github.com/TheLazron/ai/blob/2296205cede6ecd77c1dfb4b6356f42d1e9f5ca8/src/utils/getUserPRVelocity.ts#L13

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

• npm-shrinkwrap.json
• package.json

[TheLazron]

Why did changing it to Math.floor work?

[Anush008]

I suggested Math.floor() assuming that the issue was arising due to the difference in values after the decimal point in the test runner. Math.floor() rounds down to the nearest int, disregarding the decimal value.

Now that the tests pass, there are a few linting errors at https://github.com/open-sauced/ai/actions/runs/5325886058/jobs/9647205001?pr=190. Once they are resolved, we can get this merged.

[github-actions]

🎉 This PR is included in version 1.8.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀