Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: post to linkedin projects #177

Merged
merged 14 commits into from
Jun 21, 2023
Merged

feat: post to linkedin projects #177

merged 14 commits into from
Jun 21, 2023

Conversation

a0m0rajab
Copy link
Contributor

@a0m0rajab a0m0rajab commented Jun 11, 2023 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This feature is related to #58 and does the next:

  • share to linkedin project to home screen
  • add the logic for post to linkedin
  • The button only works on the repos pages
  • this is the first iteration and we can change the logic or develop it later.
  • The extension right now assumes that the developer is signedin to linkedin.

Related Tickets & Documents

closes #58

Mobile & Desktop Screenshots/Recordings

On the repo page:
image
When the repo button clicked it open linkedin and populate project name from the name of repo and description of repo.
image

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

  • need to add tests
  • need to add documentation

[optional] What gif best describes this PR or how it makes you feel?

@a0m0rajab a0m0rajab changed the title Feat post to linkedin projects feat: post to linkedin projects Jun 11, 2023
This was referenced Jun 11, 2023
Closed
Closed
@bdougie
Copy link
Member

bdougie commented Jun 13, 2023

When the repo button clicked it open linkedin and populate project name from the name of repo and description of repo.

Perhaps it is a caching thing, but I was not able to see the title and description populate when I clicked. I also think this PR will need to have documentation before being merged. Because this only works on the repository pages, most user will not know it exists. This most likely similar to the profile pages, which is also not documented.

@a0m0rajab
Copy link
Contributor Author

a0m0rajab commented Jun 13, 2023 •
edited
Loading

I did a patch to wait for the element to load, as you mentioned I think it was cached on my machine from a previous script or something.

Here is a video of the expected behavior. If it's okay, I will process with the documentation.

2023-06-14.00-43-59.mp4

@bdougie
Copy link
Member

bdougie commented Jun 14, 2023

Looks good. One more thing. Could we use the LinkedIn icon instead of the pencil?

@bdougie
Copy link
Member

bdougie commented Jun 18, 2023

@a0m0rajab checking in here to see if you could handle the merge conflicts. Also swap out the pencil with [IoLogoLinkedin](https://react-icons.github.io/react-icons/search?q=linkedin)

@a0m0rajab
Copy link
Contributor Author

image

Changed icon.

  • The next steps for this should be:
    • adding documentation
    • adding skills (programming languages)

@a0m0rajab
Copy link
Contributor Author

Tests are passed on local machine:
image

@a0m0rajab
Copy link
Contributor Author

Post merge screenshot:
image

bdougie
bdougie approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a copy update and removed a console.log

src/popup/pages/home.tsx Outdated Show resolved Hide resolved
src/popup/pages/home.tsx Outdated Show resolved Hide resolved
a0m0rajab and others added 2 commits June 19, 2023 21:34
@a0m0rajab @bdougie
Update src/popup/pages/home.tsx
54a81d1 
Co-authored-by: Brian Douglas <[email protected]>
@a0m0rajab @bdougie
update copy
2a5a50c 
Co-authored-by: Brian Douglas <[email protected]>
@bdougie
Copy link
Member

bdougie commented Jun 20, 2023

Looks like this is close, it just has one npm run lint error.

@a0m0rajab
Copy link
Contributor Author

Checks Passed 👍

@bdougie bdougie merged commit a20bff4 into open-sauced:beta Jun 21, 2023
@bdougie
Copy link
Member

bdougie commented Jun 21, 2023

please move forward with a docs when you have a moment.

github-actions bot pushed a commit that referenced this pull request Jun 21, 2023
@a0m0rajab @open-sauced
chore(minor): release 1.9.0-beta.1 on beta channel [skip ci]
4459c1a 
## [1.9.0-beta.1](v1.8.1-beta.1...v1.9.0-beta.1) (2023-06-21)

### 🍕 Features

* post to linkedin projects ([#177](#177)) ([a20bff4](a20bff4))
@github-actions
Copy link

🎉 This PR is included in version 1.9.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 29, 2023
@bdougie @open-sauced
chore(minor): release 1.9.0 [skip ci]
52dc3eb 
## [1.9.0](v1.8.0...v1.9.0) (2023-06-29)

### ✅ Tests

* Tests for colorPreference and getUserPRVelocity ([#190](#190)) ([6b9a5c3](6b9a5c3))

### 🍕 Features

* post to linkedin projects ([#177](#177)) ([a20bff4](a20bff4))

### 🐛 Bug Fixes

* Made the "Tools:" conditional according to the current page ([#197](#197)) ([b08ad07](b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)
* separate vite and vitest configs ([#193](#193)) ([7a980c8](7a980c8))
@github-actions
Copy link

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
@a0m0rajab @open-sauced
chore(minor): release 1.9.0-beta.1 on beta channel [skip ci]
ab6a63e 
## [1.9.0-beta.1](open-sauced/ai@v1.8.1-beta.1...v1.9.0-beta.1) (2023-06-21)

### 🍕 Features

* post to linkedin projects ([#177](open-sauced/ai#177)) ([a20bff4](open-sauced/ai@a20bff4))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
@bdougie @open-sauced
chore(minor): release 1.9.0 [skip ci]
bdc2df9 
## [1.9.0](open-sauced/ai@v1.8.0...v1.9.0) (2023-06-29)

### ✅ Tests

* Tests for colorPreference and getUserPRVelocity ([#190](open-sauced/ai#190)) ([6b9a5c3](open-sauced/ai@6b9a5c3))

### 🍕 Features

* post to linkedin projects ([#177](open-sauced/ai#177)) ([a20bff4](open-sauced/ai@a20bff4))

### 🐛 Bug Fixes

* Made the "Tools:" conditional according to the current page ([#197](open-sauced/ai#197)) ([b08ad07](open-sauced/ai@b08ad07)), closes [issue#112](https://github.com/open-sauced/issue/issues/112) [issue#112](https://github.com/open-sauced/issue/issues/112)
* separate vite and vitest configs ([#193](open-sauced/ai#193)) ([7a980c8](open-sauced/ai@7a980c8))
@a0m0rajab a0m0rajab mentioned this pull request Jul 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdougie bdougie bdougie approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Incorporate Linkedin features
2 participants
@a0m0rajab @bdougie