Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: carousel design for the highlights feed #173

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

diivi
Copy link
Contributor

@diivi diivi commented Jun 10, 2023

image
Might consider changing the scrollbar too:
image

This PR introduces a new carousel design for the highlights feed, ensuring uniform heights for a consistent look and feel. The new design enhances the user experience by providing a visually appealing and easy-to-use interface.

Generated using OpenSauced.

This looks like a major improvement imo, here are some edge cases (too big of a description and no title) that the earlier version could not handle too:

image
image

@diivi
Copy link
Contributor Author

diivi commented Jun 10, 2023

The API fetches 50 highlights btw, not 10 (I think we assumed it was 10 last time round).

Also, we might wanna exclude package files/assets from the Description generator, it could give me a description with diff if these files were excluded I guess. Right now the description is generated from commit messages.

src/popup/pages/home.tsx Outdated Show resolved Hide resolved
@Anush008
Copy link
Member

Looks good @diivi. The swiper and the reactions when added will make for a great interactiveness. I would recommend adding some sort of indication about the ability to swipe though.

@diivi
Copy link
Contributor Author

diivi commented Jun 10, 2023

I would recommend adding some sort of indication about the ability to swipe though.

Good Idea, I'll probably reduce the highlights to 10 and add dot indicators.

@bdougie
Copy link
Member

bdougie commented Jun 11, 2023

The swiper and the reactions when added will make for a great interactiveness. I would recommend adding some sort of indication about the ability to swipe though.

I'd expect the keyboard available to swipe left and right. I'd also recommend returning the forward and back buttons. There is no suggestion for the user to see this is a carousel.

@diivi
Copy link
Contributor Author

diivi commented Jun 13, 2023

Peek 2023-06-13 18-31
With a11y support for tabs

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ally additions are great. Also more intuitive.

@bdougie bdougie merged commit 0392654 into beta Jun 13, 2023
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
## [1.6.0-beta.1](v1.5.0...v1.6.0-beta.1) (2023-06-13)

### 🍕 Features

* carousel design for the highlights feed ([#173](#173)) ([0392654](0392654))
@github-actions
Copy link

🎉 This PR is included in version 1.6.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdougie bdougie mentioned this pull request Jun 13, 2023
github-actions bot pushed a commit that referenced this pull request Jun 13, 2023
## [1.6.0](v1.5.0...v1.6.0) (2023-06-13)

### 🍕 Features

* carousel design for the highlights feed ([#173](#173)) ([0392654](0392654))
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Anush008 Anush008 deleted the feat/carousel-sliding-highlights branch June 14, 2023 15:26
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.6.0-beta.1](open-sauced/ai@v1.5.0...v1.6.0-beta.1) (2023-06-13)

### 🍕 Features

* carousel design for the highlights feed ([#173](open-sauced/ai#173)) ([0392654](open-sauced/ai@0392654))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.6.0](open-sauced/ai@v1.5.0...v1.6.0) (2023-06-13)

### 🍕 Features

* carousel design for the highlights feed ([#173](open-sauced/ai#173)) ([0392654](open-sauced/ai@0392654))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants