-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: carousel design for the highlights feed #173
Conversation
The API fetches 50 highlights btw, not 10 (I think we assumed it was 10 last time round). Also, we might wanna exclude package files/assets from the Description generator, it could give me a description with diff if these files were excluded I guess. Right now the description is generated from commit messages. |
Looks good @diivi. The swiper and the reactions when added will make for a great interactiveness. I would recommend adding some sort of indication about the ability to swipe though. |
Good Idea, I'll probably reduce the highlights to 10 and add dot indicators. |
I'd expect the keyboard available to swipe left and right. I'd also recommend returning the forward and back buttons. There is no suggestion for the user to see this is a carousel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ally additions are great. Also more intuitive.
## [1.6.0-beta.1](v1.5.0...v1.6.0-beta.1) (2023-06-13) ### 🍕 Features * carousel design for the highlights feed ([#173](#173)) ([0392654](0392654))
🎉 This PR is included in version 1.6.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.6.0](v1.5.0...v1.6.0) (2023-06-13) ### 🍕 Features * carousel design for the highlights feed ([#173](#173)) ([0392654](0392654))
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [1.6.0-beta.1](open-sauced/ai@v1.5.0...v1.6.0-beta.1) (2023-06-13) ### 🍕 Features * carousel design for the highlights feed ([#173](open-sauced/ai#173)) ([0392654](open-sauced/ai@0392654))
## [1.6.0](open-sauced/ai@v1.5.0...v1.6.0) (2023-06-13) ### 🍕 Features * carousel design for the highlights feed ([#173](open-sauced/ai#173)) ([0392654](open-sauced/ai@0392654))
Might consider changing the scrollbar too:
This PR introduces a new carousel design for the highlights feed, ensuring uniform heights for a consistent look and feel. The new design enhances the user experience by providing a visually appealing and easy-to-use interface.
Generated using OpenSauced.
This looks like a major improvement imo, here are some edge cases (too big of a description and no title) that the earlier version could not handle too: