Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extension settings #132

Merged
merged 11 commits into from
Jun 5, 2023
Merged

feat: extension settings #132

merged 11 commits into from
Jun 5, 2023

Conversation

diivi
Copy link
Contributor

@diivi diivi commented May 25, 2023

image
I'll add every feature that we've added here separately.

Should fix #103

Also moved all pages to popup/pages/ from pages/, and made a new directory for popup components.

@bdougie
Copy link
Member

bdougie commented May 25, 2023

This will need a rebase from beta for a lint and merge conflict fix.

@diivi
Copy link
Contributor Author

diivi commented May 28, 2023

I added a setting to enable/disable AI PR Descriptions, it works.
I will add settings to toggle other injected components too.

Open to testing AI PR Desc for now.

@diivi diivi marked this pull request as ready for review May 28, 2023 08:41
@bdougie
Copy link
Member

bdougie commented May 29, 2023

I see the feature is off by default in the settings, but it is on in the description settings. Do we need to add global state management?

Screen Shot 2023-05-29 at 8 26 27 AM Screen Shot 2023-05-29 at 8 26 36 AM

@diivi
Copy link
Contributor Author

diivi commented May 29, 2023

Do we need to add global state management?

I guess I could disable the toggle buttons for AI features when AI Configuration is turned off.

Or we could simply remove the power button from the AI Configuration menu, since for enabling and disabling stuff the user will just look for it in the Settings Tab.

@diivi
Copy link
Contributor Author

diivi commented May 29, 2023

I am removing the power button and shifting all repsonsibility of enabling/disabling stuff to the Settings Panel (confirmed with @Anush008)

@diivi
Copy link
Contributor Author

diivi commented Jun 1, 2023

@bdougie what other stuff were you planning to make optional? I am adding toggles for AI PR Description and Suggest Code Refactor features.

@bdougie
Copy link
Member

bdougie commented Jun 2, 2023

All ai features and the upvote feature when it re-ships.

@bdougie
Copy link
Member

bdougie commented Jun 2, 2023

Aside from merge conflicts, I think this might be close to merge ready.

@diivi
Copy link
Contributor Author

diivi commented Jun 4, 2023

Added Settings for both our AI features, code refactor and AI PR description, they work the same way.

@diivi diivi requested review from bdougie and Anush008 June 5, 2023 09:07
Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and merging. But just want to point out, we really need to document these features.

https://docs.opensauced.pizza/chrome-extension/using-the-chrome-extension/

@bdougie bdougie merged commit 722cbbe into beta Jun 5, 2023
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
## [1.5.0-beta.1](v1.4.1-beta.3...v1.5.0-beta.1) (2023-06-05)

### 🍕 Features

* extension settings ([#132](#132)) ([722cbbe](722cbbe))
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

🎉 This PR is included in version 1.5.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 6, 2023
## [1.5.0](v1.4.0...v1.5.0) (2023-06-06)

### 🧑‍💻 Code Refactoring

* removed post highlight message passing  ([#165](#165)) ([bad2112](bad2112))

### 🍕 Features

* extension settings ([#132](#132)) ([722cbbe](722cbbe))

### 🐛 Bug Fixes

* highlight redirection, multiple AI generation, draft commit messages ([#163](#163)) ([03b91ab](03b91ab))
* post-highlight-page-check ([#164](#164)) ([ed98eb2](ed98eb2))
* remove configuration enabled check from AI button ([#170](#170)) ([cedca79](cedca79))
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Anush008 Anush008 deleted the feat/extension-settings branch June 11, 2023 10:54
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.5.0-beta.1](open-sauced/ai@v1.4.1-beta.3...v1.5.0-beta.1) (2023-06-05)

### 🍕 Features

* extension settings ([#132](open-sauced/ai#132)) ([722cbbe](open-sauced/ai@722cbbe))
zer0and1 pushed a commit to zer0and1/open-sauced.ai that referenced this pull request Jul 26, 2023
## [1.5.0](open-sauced/ai@v1.4.0...v1.5.0) (2023-06-06)

### 🧑‍💻 Code Refactoring

* removed post highlight message passing  ([#165](open-sauced/ai#165)) ([bad2112](open-sauced/ai@bad2112))

### 🍕 Features

* extension settings ([#132](open-sauced/ai#132)) ([722cbbe](open-sauced/ai@722cbbe))

### 🐛 Bug Fixes

* highlight redirection, multiple AI generation, draft commit messages ([#163](open-sauced/ai#163)) ([03b91ab](open-sauced/ai@03b91ab))
* post-highlight-page-check ([#164](open-sauced/ai#164)) ([ed98eb2](open-sauced/ai@ed98eb2))
* remove configuration enabled check from AI button ([#170](open-sauced/ai#170)) ([cedca79](open-sauced/ai@cedca79))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Settings panel
2 participants