Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: The manifest shouldn't be bumped when pushed to beta #121

Closed
2 tasks done
Anush008 opened this issue May 25, 2023 · 2 comments · Fixed by #124
Closed
2 tasks done

Bug: The manifest shouldn't be bumped when pushed to beta #121

Anush008 opened this issue May 25, 2023 · 2 comments · Fixed by #124

Comments

@Anush008
Copy link
Member

Anush008 commented May 25, 2023

Describe the bug

Currently the manifest.json version value is being bumped according to sematic-commits. A push to beta bumps the version number to something like 1.2.0-beta.4.
Which is not allowed by web-browsers. Since the manifest version number should only be dot seperated integers between 0 and 655536. Like 1.2.0. That is the version number when released to main. Hence, the version value should only be bumped when released on the main branch.

Screenshot 2023-05-25 050653.png

Steps to reproduce

  1. Build a the current version of the extension using npm build.
  2. Try to add the extension to your brower at chrome://extensions.

Affected services

browser-extension

Platforms

No response

Browsers

Chrome, Edge

Environment

Production, Development

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@Anush008 Anush008 added 🐛 bug Something isn't working priority: high labels May 25, 2023
0-vortex pushed a commit to open-sauced/release that referenced this issue May 25, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant