Feat: Allow local images #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1494
to
+1497
| if (Http::getEnv('OPR_EXECUTOR_IMAGE_PULL', 'enabled') === 'disabled') { | ||
| // Useful to prevent auto-pulling from remote when testing local images | ||
| Console::info("Skipping image pulling"); | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| if (Http::getEnv('OPR_EXECUTOR_IMAGE_PULL', 'enabled') === 'disabled') { | |
| // Useful to prevent auto-pulling from remote when testing local images | |
| Console::info("Skipping image pulling"); | |
| } else { | |
| if (Http::getEnv('OPR_EXECUTOR_IMAGE_PULL', 'enabled') === 'disabled') { | |
| // Useful to prevent auto-pulling from remote when testing local images | |
| Console::info("Skipping image pulling"); | |
| return; | |
| } |
Can we do something like this to remove the else block and make a bit less indentation to make it readable?
There was a problem hiding this comment.
Sadly not in this scenario, code continues to start http server.
I like the idea, and it is possible to allow this, but that would make PR diff even bigger and more complex. I would like to avoid that as I want this PR merged quickly.
lohanidamodar
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In development mode, prevent pulling images.
If no image is pulled yet, first run will take extra time. But this gives great benefit when local images are different than remote. Without this change, executor always pulls latest from remote, overriding any local changes.
Manual QA: