Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple custom transport cleanup #312

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

shanejonas
Copy link
Member

@shanejonas shanejonas commented Sep 3, 2021

This PR fixes a bug in the inspector custom transports where it wouldn't get cleaned up, as well as fixes a bug with grabbing the incorrect transport.

src/hooks/useTransport.ts Outdated Show resolved Hide resolved
src/hooks/useTransport.ts Outdated Show resolved Hide resolved
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shanejonas shanejonas merged commit 12f5ee9 into master Sep 3, 2021
@shanejonas shanejonas deleted the fix/multiple-custom-transport-cleanup branch September 3, 2021 22:23
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants