Cancel automatic pending tasks that are removed during new assignments #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Yadunund
reviewed
Sep 18, 2023
Signed-off-by: Aaron Chong <[email protected]>
Yadunund
approved these changes
Sep 28, 2023
aaronchongth
added a commit
that referenced
this pull request
Sep 28, 2023
#301) * Cancel automatic pending tasks that are removed during new assignments Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Use unordered_set Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit fb23496) Signed-off-by: Aaron Chong <[email protected]>
aaronchongth
added a commit
that referenced
this pull request
Sep 28, 2023
#301) * Cancel automatic pending tasks that are removed during new assignments Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Use unordered_set Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> (cherry picked from commit fb23496) Signed-off-by: Aaron Chong <[email protected]>
This was referenced Sep 28, 2023
arjo129
pushed a commit
that referenced
this pull request
Jun 7, 2024
#301) * Cancel automatic pending tasks that are removed during new assignments Signed-off-by: Aaron Chong <[email protected]> * Lint Signed-off-by: Aaron Chong <[email protected]> * Use unordered_set Signed-off-by: Aaron Chong <[email protected]> --------- Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Not exactly a bug, but at the moment pending automatic tasks are just removed from the queue without cancellation.
The original automatic task will remain as
queuedforever on the end of theapi-server.This publishes the cancellation of those pending tasks that will be removed when new assignments happen.