Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added piston, syringe and peristaltic pump options for addition devices. #736

Merged

Conversation

bdeadman
Copy link
Collaborator

Added piston, syringe and peristaltic pump options for addition devices. This will set us up to better capture flow chemistry reactions.

@bdeadman
Copy link
Collaborator Author

Note that the protocol buffers have not been compiled so that will need to be done first before merging into main.

@bdeadman bdeadman mentioned this pull request Jul 11, 2024
@bdeadman
Copy link
Collaborator Author

This is PR #734 after fixes and redirecting to a branch.

@bdeadman
Copy link
Collaborator Author

Waiting for issue #735 before compiling.

@skearnes skearnes self-requested a review July 26, 2024 14:26
@skearnes skearnes merged commit 7dedc68 into open-reaction-database:enum_additions Jul 26, 2024
19 checks passed
skearnes pushed a commit that referenced this pull request Sep 27, 2024
…es. (#736) (#751)

* added pump enums

* removed other pump

* changed tabs to spaces

* compiled the proto wrappers after recent addition of pump enums

* ran forma.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants