Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to psycopg 3 #730

Merged
merged 17 commits into from
Jul 4, 2024
Merged

Upgrade to psycopg 3 #730

merged 17 commits into from
Jul 4, 2024

Conversation

skearnes
Copy link
Collaborator

@skearnes skearnes commented Jul 4, 2024

  • Use psycopg>=3 instead of psycopg2
  • Test on multiple python versions
  • Expose rdkit types and rename the table objects to their plural forms

@skearnes skearnes marked this pull request as ready for review July 4, 2024 04:57
@skearnes skearnes requested a review from qai222 July 4, 2024 04:57
@skearnes skearnes enabled auto-merge (squash) July 4, 2024 04:58
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.27%. Comparing base (4f50b68) to head (523c58c).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   69.89%   70.27%   +0.38%     
==========================================
  Files          23       23              
  Lines        2368     2345      -23     
  Branches      598      608      +10     
==========================================
- Hits         1655     1648       -7     
+ Misses        599      586      -13     
+ Partials      114      111       -3     
Files Coverage Δ
ord_schema/message_helpers.py 87.04% <100.00%> (+0.97%) ⬆️

... and 22 files with indirect coverage changes

@skearnes skearnes changed the title Test multiple python versions Upgrade to psycopg 3 Jul 4, 2024
@skearnes skearnes requested a review from bdeadman July 4, 2024 17:12
@skearnes skearnes merged commit 16cdf28 into open-reaction-database:main Jul 4, 2024
19 checks passed
@skearnes skearnes deleted the matrix branch July 4, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants