Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a template/checklist for reviewers #528

Open
skearnes opened this issue Jan 5, 2021 · 2 comments
Open

Create a template/checklist for reviewers #528

skearnes opened this issue Jan 5, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@skearnes
Copy link
Collaborator

skearnes commented Jan 5, 2021

Should cover the relevant things such that a second reviewer could quickly grasp what the first reviewer has already verified or looked for...

@skearnes skearnes added the enhancement New feature or request label Jan 5, 2021
@FanwangM
Copy link
Collaborator

FanwangM commented Aug 31, 2023

This is not exactly what @skearnes means above, but we can have a checking action run automatically every time there is a data pull request for reaction submission. If not all the list points are checked, the GitHub Action will raise an error, which can be done with https://github.com/marketplace/actions/task-completed-checker. Something like,

image

The [task-completed-checker-action](https://github.com/kentaro-m/task-completed-checker-action) configurations should sit in https://github.com/open-reaction-database/ord-data, not here.

What do you think of this? @connorcoley @skearnes

@bdeadman
Copy link
Collaborator

Created a complementary issue ticket in ord-data to handle the dataset review procedure open-reaction-database/ord-data#180 (comment).

Leaving this issue open as I will be documenting the process for modifying ord-schema when I make changes for #708 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants