Update OpenSSH downstream branch to OQS-v9 #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Wilson <[email protected]>
|
@geedo0 You'll need to set the workflow in OpenSSH to be triggered on |
|
Ack, added the trigger to the PR here. |
|
Apparently the GitHub trigger won't do anything unless the downstream workflow is on the default branch: see open-quantum-safe/openssh#168 (comment) for discussion. |
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: Spencer Wilson <[email protected]>
This reverts commit ba4a551. Signed-off-by: Spencer Wilson <[email protected]>
|
Trigger tested on commit caea971: see the upstream and and downstream runs. For testing, I disabled the other downstream triggers and set the workflow to be triggered on pushes to this branch; the most recent commit reverts these changes. |
dstebila
approved these changes
Aug 21, 2024
geedo0
approved these changes
Aug 21, 2024
praveksharma
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per open-quantum-safe/openssh#166.
* [ ] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)* [ ] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)