Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check return value of fscanf in LMS/XMSS KAT tests #1874

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Check return value of fscanf in LMS/XMSS KAT tests #1874

merged 2 commits into from
Jul 29, 2024

Conversation

SWilson4
Copy link
Member

Gets rid of some annoying compiler warnings.

Fixes #1871.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4
Check return value of fscanf
d761b1f 
Signed-off-by: Spencer Wilson <[email protected]>
@SWilson4 SWilson4 requested a review from dstebila as a code owner July 29, 2024 19:17
@SWilson4
Run format script
c37c532 
Signed-off-by: Spencer Wilson <[email protected]>
@SWilson4 SWilson4 requested review from baentsch, ashman-p and cothan July 29, 2024 19:18
@SWilson4 SWilson4 merged commit 3488f0a into main Jul 29, 2024
120 checks passed
@SWilson4 SWilson4 deleted the sw-fix-warnings branch July 29, 2024 21:43
rtjk pushed a commit to rtjk/liboqs that referenced this pull request Aug 5, 2024
@SWilson4 @rtjk
Check return value of fscanf in LMS/XMSS KAT tests (open-quantum-safe…
d6ee590 
…#1874)

Signed-off-by: Spencer Wilson <[email protected]>
Signed-off-by: rtjk <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashman-p ashman-p ashman-p approved these changes

@cothan cothan cothan approved these changes

@dstebila dstebila Awaiting requested review from dstebila dstebila is a code owner

@baentsch baentsch Awaiting requested review from baentsch baentsch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected warning output
3 participants
@SWilson4 @cothan @ashman-p