Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-KEM NIST tests, fix order of d and z #1854

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ML-KEM NIST tests, fix order of d and z #1854

merged 2 commits into from
Jul 24, 2024

Conversation

bhess
Copy link
Member

@bhess bhess commented Jul 23, 2024

Thank you for catching the issue @abhinav-thales! Could you please confirm if this fixes the issue?

Fixes #1853

@bhess bhess requested a review from dstebila as a code owner July 23, 2024 12:58
@abhinav-thales
Copy link
Contributor

changes look good @bhess

may be a comment update here could also help.

Signed-off-by: Basil Hess <[email protected]>
@bhess
Copy link
Member Author

bhess commented Jul 24, 2024

may be a comment update here could also help.

Updated in 2f630e0, thanks!

@bhess bhess merged commit 476f835 into main Jul 24, 2024
2 checks passed
@bhess bhess deleted the bhe-nistvec-dz branch July 24, 2024 06:45
rtjk pushed a commit to rtjk/liboqs that referenced this pull request Aug 5, 2024
* ML-KEM NIST tests, fix order of d and z

---------

Signed-off-by: Basil Hess <[email protected]>
Signed-off-by: rtjk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Order of z and d in NIST tests
4 participants