Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Kyber from libjade #1745

Merged
merged 84 commits into from
Aug 18, 2024
Merged

Integrate Kyber from libjade #1745

merged 84 commits into from
Aug 18, 2024

Commits on Jul 16, 2024

  1. Add copy_from_libjade.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    de97c41 View commit details
    Browse the repository at this point in the history

  2. Modify copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ddcfdb3 View commit details
    Browse the repository at this point in the history

  3. Add patches for libjade Kyber code 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a18fa2a View commit details
    Browse the repository at this point in the history

  4. Update alg_support.cmake templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e81c66e View commit details
    Browse the repository at this point in the history

  5. Update KEM famiy templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    75b33ba View commit details
    Browse the repository at this point in the history

  6. Fix copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7137e8c View commit details
    Browse the repository at this point in the history

  7. Correct copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    532cadf View commit details
    Browse the repository at this point in the history

  8. Modify copy_from_upstream.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4912808 View commit details
    Browse the repository at this point in the history

  9. Update KEM family templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8b8a7ef View commit details
    Browse the repository at this point in the history

  10. Fix copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    cca5cd4 View commit details
    Browse the repository at this point in the history

  11. Fix KEM family templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0b4af0b View commit details
    Browse the repository at this point in the history

  12. Fix KEM family templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e1238f9 View commit details
    Browse the repository at this point in the history

  13. Update templates for build system files 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4d6aa1f View commit details
    Browse the repository at this point in the history

  14. Update build system files 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    41b4af6 View commit details
    Browse the repository at this point in the history

  15. Fix add_enable_by_alg_conditional.libjade 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0cd7af0 View commit details
    Browse the repository at this point in the history

  16. Run copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d62113d View commit details
    Browse the repository at this point in the history

  17. Update KEM family templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32b2f99 View commit details
    Browse the repository at this point in the history

  18. Update KEM templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    71577e1 View commit details
    Browse the repository at this point in the history

  19. Update KEM templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    87d39de View commit details
    Browse the repository at this point in the history

  20. Update copy_from_upstream.yml with libjade implementation info 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0bd3be8 View commit details
    Browse the repository at this point in the history

  21. Update KEM templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a1450bf View commit details
    Browse the repository at this point in the history

  22. Edit KEM templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1bc0ff7 View commit details
    Browse the repository at this point in the history

  23. Run copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    06b1036 View commit details
    Browse the repository at this point in the history

  24. Update copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    36a1dcf View commit details
    Browse the repository at this point in the history

  25. Fix KEM temlates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    70fd60f View commit details
    Browse the repository at this point in the history

  26. Run copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    421886a View commit details
    Browse the repository at this point in the history

  27. Add libjade_shim 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d5bc956 View commit details
    Browse the repository at this point in the history

  28. Add jasmin/libjade namespaces to test_binary.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    79ccabf View commit details
    Browse the repository at this point in the history

  29. Update testing 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6f5a968 View commit details
    Browse the repository at this point in the history

  30. Allow manually triggering CI tests 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1b6034f View commit details
    Browse the repository at this point in the history

  31. Change container for upstreamcheck in unix.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f418438 View commit details
    Browse the repository at this point in the history

  32. Update copy_from_upstream.py 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    109092e View commit details
    Browse the repository at this point in the history

  33. Edit unix.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f8ca495 View commit details
    Browse the repository at this point in the history

  34. Edit unix.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    578eab7 View commit details
    Browse the repository at this point in the history

  35. Restrict copying of code from libjade repo to relevant files 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    176c5cb View commit details
    Browse the repository at this point in the history

  36. Remove irrelevant libjade code 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f2c6c04 View commit details
    Browse the repository at this point in the history

  37. Remove redundant KEM templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    123d4c8 View commit details
    Browse the repository at this point in the history

  38. Update KEM template to accomodate new dir structure 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4e92667 View commit details
    Browse the repository at this point in the history

  39. Debug: tweak unix.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d0e72a9 View commit details
    Browse the repository at this point in the history

  40. Re-build libjade with jasmin version used in CI 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7f5ec38 View commit details
    Browse the repository at this point in the history

  41. Debug: undo unix.yml tweak 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d26f552 View commit details
    Browse the repository at this point in the history

  42. Allow MSVC to ignore libjade_shims 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    88d1997 View commit details
    Browse the repository at this point in the history

  43. Simplify name scheme for libjade code 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c79a15a View commit details
    Browse the repository at this point in the history

  44. Update alg docs, libjade code name scheme, and license 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    762ba8d View commit details
    Browse the repository at this point in the history

  45. Update copy_from_upstream documentation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0f1d3bd View commit details
    Browse the repository at this point in the history

  46. Fix copy_from_upstream.py and simply libjade code name scheme 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    92df906 View commit details
    Browse the repository at this point in the history

  47. Update alg docs and CBOM 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ff78985 View commit details
    Browse the repository at this point in the history

  48. Correct alg doc generation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e741027 View commit details
    Browse the repository at this point in the history

  49. Generate CBOM with unique bom-ref 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32de1d2 View commit details
    Browse the repository at this point in the history

  50. Cleanup unix.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4213a66 View commit details
    Browse the repository at this point in the history

  51. fix patches to include api.c; fix kem templates 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2819622 View commit details
    Browse the repository at this point in the history

  52. fix kyber patch 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7f46047 View commit details
    Browse the repository at this point in the history

  53. turn off weekly constant time tests for libjade implementations 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ba7bedf View commit details
    Browse the repository at this point in the history

  54. update documentation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a53ce69 View commit details
    Browse the repository at this point in the history

  55. change upstream to stable libjade release 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    35e34b0 View commit details
    Browse the repository at this point in the history

  56. fix kyber documentation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    30b3259 View commit details
    Browse the repository at this point in the history

  57. fix kyber documentation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e962361 View commit details
    Browse the repository at this point in the history

  58. fix kem template again 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6eae7d0 View commit details
    Browse the repository at this point in the history

  59. fix weekly.yml and unix.yml to test libjade code 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    eec545b View commit details
    Browse the repository at this point in the history

  60. rename libjade asm files from *.s to *.S 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e1b0edf View commit details
    Browse the repository at this point in the history

  61. end libjade_kyber*/api.c files with newline 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    17ed11e View commit details
    Browse the repository at this point in the history

  62. fix kem template to prevent duplicate symbols in object files 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    6368bcc View commit details
    Browse the repository at this point in the history

  63. fix indentation in weekly.yml 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2255ed7 View commit details
    Browse the repository at this point in the history

  64. skip testing libjade on macos-14 in CI 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3783c4f View commit details
    Browse the repository at this point in the history

  65. use release tag/branch with libjade upstream url instead of commit 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5c40696 View commit details
    Browse the repository at this point in the history

  66. fix build error when OQS_ENABLE_LIBJADE_KEM_ALG=OFF 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    05b069e View commit details
    Browse the repository at this point in the history

  67. initialize LIBJADE_RANDOMBYTES when OQS_LIBJADE_BUILD=OFF 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    54598ad View commit details
    Browse the repository at this point in the history

  68. remove redundant comment 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    5b11e20 View commit details
    Browse the repository at this point in the history

  69. fix comment typo 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    f5f64f3 View commit details
    Browse the repository at this point in the history

  70. make string explicit when comparing with variable in cmake 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b8cd0be View commit details
    Browse the repository at this point in the history

  71. add libjade kyber licensing to README.md 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    efb20eb View commit details
    Browse the repository at this point in the history

  72. remove reference to oldpqclean_kyber* code from libjade if branchin k… 

    …em_kyber_*.c

Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2107194 View commit details
    Browse the repository at this point in the history

  73. Update CMakeLists.txt 

    Co-authored-by: Spencer Wilson <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma @SWilson4
    praveksharma and SWilson4 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ad8d626 View commit details
    Browse the repository at this point in the history

  74. track jasminc version in copy_from_libjade.yml; check jasminc version… 

    … in copy_from_upstream.py

Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7d92d32 View commit details
    Browse the repository at this point in the history

  75. add OQS_LIBJADE_BUILD to build flags output 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d27901f View commit details
    Browse the repository at this point in the history

  76. remove link from CONFIGURE.md 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3796695 View commit details
    Browse the repository at this point in the history

  77. Update libjade to dual license 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    597c78a View commit details
    Browse the repository at this point in the history

  78. Patch gcc version for MacOS CI runs 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    14dcca7 View commit details
    Browse the repository at this point in the history

  79. Merge branch 'main' into ps-jasmin

    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b10de91 View commit details
    Browse the repository at this point in the history

  80. Fix doc generation 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1b17ad9 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Fix libjade docs 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    bb888d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2024

  1. fix license info in README.md 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    6eeeb53 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ps-jasmin 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma authored Aug 11, 2024
    Configuration menu
    Copy the full SHA
    3721500 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. update libjade_randombytes spdx-license 

    Signed-off-by: Pravek Sharma <[email protected]>
    @praveksharma
    praveksharma committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    b1c4950 View commit details
    Browse the repository at this point in the history