Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abort() instead of exit() to get the trace log. #1728

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Use abort() instead of exit() to get the trace log. #1728

merged 1 commit into from
Mar 12, 2024

Conversation

ducnguyen-sb
Copy link
Contributor

I find that if we use exit(), we don't know where it goes wrong.

So if we switch to abort(), we will have the trace where it crashed.

abort() causes abnormal program termination and does not call functions registered with atexit() or destructors for objects with automatic storage duration.[[1]](https://en.cppreference.com/w/c/program/abort) It is generally used to immediately terminate the program when a fatal error occurs.

also, abort() will cause a signal, and it's up to application to decide what to do with the signal.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@ducnguyen-sb ducnguyen-sb merged commit 3640484 into stateful-sigs Mar 12, 2024
85 of 86 checks passed
@ducnguyen-sb ducnguyen-sb deleted the use_abort branch March 12, 2024 16:49
cothan pushed a commit that referenced this pull request Apr 2, 2024
@ducnguyen-sb @cothan
Use abort() instead of exit to get the trace log. (#1728)
9302454
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @SWilson4
Use abort() instead of exit to get the trace log. (#1728)
175d5b9
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @SWilson4
Use abort() instead of exit to get the trace log. (#1728)
b8c4123
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@ducnguyen-sb @SWilson4
Use abort() instead of exit to get the trace log. (#1728)
e250e31
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@ducnguyen-sb @SWilson4
Use abort() instead of exit to get the trace log. (#1728)
b45415c
cothan added a commit that referenced this pull request May 30, 2024
@cothan
I, Duc Nguyen, retroactively sign off on these commits:
d37f20d 
commit 244288f Add XMSS parameter xmss_sha256_h10 (#1482)
commit a7e26d9 Add 12 XMSS and 16 XMSSMT parameters. (#1489)
commit 4694fc3 Add secret key object to XMSS (#1530)
commit 99067be Add XMSS Serialize/Deserialize  (#1542)
commit 2dbfc40 Update XMSS secret key object APIs, sync with LMS  (#1588)
commit 47740ad Enforce idx from unsigned int to uint32_t. (#1611)
commit 9610576 Fix windows-x86 and arm compiling error. (#1634)
commit bb658b7 Address  stateful-sigs comments in #1650 (#1656)
commit 7db8ddf Update `sig_stfl.h` document for #1650 (#1655)
commit c3e5750 Add Apache 2.0 and MIT License to XMSS (#1662)
commit e1f02b2 Change XMSS License from `(Apache 2.0 AND MIT)` to `(Apache 2.0 OR MIT) AND CC0-1.0` (#1697)
commit 17c12c3 Add return status for XMSS lock/unlock functions. (#1712)
commit 1941636 Add return check for lock/unlock function (#1727)
commit b45415c Use `abort()` instead of exit to get the trace log. (#1728)
commit ba63672 Reduce number of `malloc/free` call in `XMSS/external` (#1724)

Signed-off-by: Duc Tri Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashman-p ashman-p ashman-p approved these changes

@SWilson4 SWilson4 Awaiting requested review from SWilson4

@baentsch baentsch Awaiting requested review from baentsch

@dstebila dstebila Awaiting requested review from dstebila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducnguyen-sb @ashman-p