Make internal API available to (only) test programs #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also should mention that I deleted the |
4 tasks
dstebila
approved these changes
Jan 17, 2024
baentsch
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Thanks @SWilson4 for this PR: After a first review, it looks good to me -- and reduces the "OQS support interface width" as (I think is) desirable. Allow me a bit more time to "test-drive" this branch in an oqs-provider setup. If you feel there's other sub-projects that may benefit from such test, be my guest :)
baentsch
approved these changes
Jan 22, 2024
This was referenced Mar 11, 2024
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 8, 2024
This restores the now-private headers as public again after open-quantum-safe#1667, exposing the API to select alternative implementation through callbacks, e.g., OQS_AES_set_callbacks. Note the other functions in those headers are still not exposed as they are declared without OQS_API. Signed-off-by: Daiki Ueno <[email protected]>
2 tasks
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 9, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 9, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 10, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 10, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 10, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/liboqs
that referenced
this pull request
Jul 10, 2024
This makes the callback API to replace low-level cryptographic implementation public again after open-quantum-safe#1667. Signed-off-by: Daiki Ueno <[email protected]>
SWilson4
pushed a commit
that referenced
this pull request
Jul 11, 2024
…1832) This makes the callback API to replace low-level cryptographic implementation public again after #1667. Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves three purposes:
It does so by doing the following:
oqs-internallibrary, with visibility set to "default"..hfiles fromoqs.hand.Doxyfile.#includestatements as necessary to address compilation failures due to the above.oqsandoqs-internal.This will hopefully make testing easier and in particular will unblock PR #1560. I've added it to the 0.10.0 milestone for the latter reason.
Fixes #1648.
Yes, the API is changed, but it's not much. The NIST DRBG is no longer exposed in the public API. This means changes to two public API functions:
OQS_randombytes_switch_algorithmwill now error when passed the string "NIST-KAT" (with or without capitalization) andOQS_randombytes_nist_kat_init_256bithas been deleted.