-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync algs with liboqs and oqs-provider #124
Conversation
* Add CROSS * Update ML-KEM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this PR: This seems to be removing for example p256_falcon512: Why? In which way does this sync with liboqs?
@baentsch Although I've added hybrid signatures to OQS-BoringSSL, I prefer to keep the clienthello size small by not enabling them by default. However, we do need to test these hybrid signature algorithms. Since we only have four types—
This setup is easy to remember: mldsa with elliptic curves and falcon with rsa3072. It's a clean and straightforward way to track which algorithms are enabled. |
@baentsch Do you have any additional comments? If not, I'll go ahead and merge this PR. I'll update the commit message to include that "we changed the default hybrid signature algorithms." |
And that actually is the purpose of the PR, no "sync with liboqs/oqsprovider", right? Wouldn't it be fair to say that this PR creates a stronger difference between oqsprovider and boringssl even? If so, should this be documented somewhere so users understand (the rationale)? |
@baentsch It syncs with oqs-provider by updating the ML-KEM code points.
I think it's clear that oqs-boringssl supports only a subset of algorithms available in oqs-provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK as per
label it as "update algorithms," and the commit message will be:
Add CROSS
Update ML-KEM
Change default enabled hybrid signature algorithms
No description provided.