Update http.send test to work w/o internet access #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-policy-agent#945 Signed-off-by: Ashutosh Narkar <[email protected]>
srenatus
approved these changes
Sep 14, 2018
|
|
||
| // run the test | ||
| runTopDownTestCase(t, data, "http.send", rule, resultObj.String()) | ||
| } | ||
|
|
||
| func getTestServer() (baseURL string, teardownFn func()) { |
There was a problem hiding this comment.
[nit] There's no need to name the return arguments here, I think. (As long as we avoid "naked returns", it doesn't matter much, though.
|
LGTM. Agreed w/ @srenatus that named returns are not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #945
Signed-off-by: Ashutosh Narkar [email protected]