Fix improper formatter behavior when comprehension contains comment #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjons
force-pushed
the
tjons/6999-formatter-moves-comment
branch
2 times, most recently
from
7440194 to
41ecf72
Compare
tjons
force-pushed
the
tjons/6999-formatter-moves-comment
branch
2 times, most recently
from
73e4db2 to
6306139
Compare
Signed-off-by: Tyler Schade <[email protected]>
tjons
force-pushed
the
tjons/6999-formatter-moves-comment
branch
from
6306139 to
f5cd4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Resolves #6999.
What are the changes in this PR?
When a comprehension is followed by a index retrieving a value from the comprehension, the OPA AST treats that as a
ref.refs of this sort may contain comments, but the formatter did not write them inline. Since the formatter did not write them inside the comprehension body, the comments were left over and written at the end of the document.Notes to assist PR review:
The
elsehandling for the formatter is getting a bit gnarly. Constructing a fake ref for theelsefeels like something that can be handled better, but is not in scope for this PR imo.Further comments: