Support reading AWS token from the filesystem #6997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddalozzo
force-pushed
the
aws-metadata-token-file
branch
from
7347b4b
to
bed1043
Compare
cmaddalozzo
force-pushed
the
aws-metadata-token-file
branch
from
5a0ea83
to
13ac995
Compare
Signed-off-by: Curtis Maddalozzo <[email protected]>
Signed-off-by: Curtis Maddalozzo <[email protected]>
ashutosh-narkar
force-pushed
the
aws-metadata-token-file
branch
from
13ac995
to
599b02b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6724
Why the changes in this PR are needed?
PR #6894 adds support for the AWS container credential provider but it is missing support for providing the token as file via the
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEenvironment variable. This mechanism is used by EKS pod identities.What are the changes in this PR?
When using the container credential provider we will attempt to load the token from file if
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILEis set. If bothAWS_CONTAINER_AUTHORIZATION_TOKENandAWS_CONTAINER_AUTHORIZATION_TOKEN_FILEare set the former takes precedence.Notes to assist PR review:
The changes in this PR have been confirmed working in EKS.