perf: cache schema types

[nikpivkin]

This PR adds caching of schema types.

Fixes: #6969

[simar7]

@anderseknert any ETA on when we would be able to land this? Currently we'd have to implement some workarounds prior to this getting landed for our next release.

[anderseknert]

Looks like a small enough change to be able to land before the next release goes out this week. @ashutosh-narkar and @johanfylling's call.

[ashutosh-narkar]

We can move this above

if refType == nil {
	continue
}

and keep the original check

if ref == nil && refType == nil {
    continue
}

[nikpivkin]

Fixed

[ashutosh-narkar]

This change looks good. It would be helpful if you could add a test case.

[anderseknert]

The type checker can't be accessed concurrently, right? 😅

[ashutosh-narkar]

The type checker can't be accessed concurrently, right? 😅

There are existing map fields and I don't see a mutex so maybe not. Or maybe we have one at the call site. But I haven't checked the code.

[netlify]

✅ Deploy Preview for openpolicyagent ready!

Name	Link
🔨 Latest commit	f761af5
🔍 Latest deploy log	https://app.netlify.com/sites/openpolicyagent/deploys/66d7767e275be300081a9d95
😎 Deploy Preview	https://deploy-preview-6970--openpolicyagent.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nikpivkin]

@ashutosh-narkar How can you test caching if it's an internal implementation? Need to add performance tests?

[nikpivkin]

The tests on darwin failed, but from the logs I don't see why.

[ashutosh-narkar]

@ashutosh-narkar How can you test caching if it's an internal implementation? Need to add performance tests?

If we could add some unit tests for checkRule for example that exercise the cache, that would be great.

[simar7]

The tests on darwin failed, but from the logs I don't see why.

@ashutosh-narkar @anderseknert do you know why the tests are failing? We don't see results in the CI log output stating anything is failing.

[nikpivkin]

Hi @ashutosh-narkar . The tests already cover all cache use cases. How can a test look like, without breaking encapsulation and explicitly checking for the presence of values in the cache?