loader: Avoid reading UNC paths by default #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
reviewed
Aug 15, 2024
loader/loader_test.go
Outdated
|
|
||
| for _, tc := range cases { | ||
| t.Run(tc.input, func(t *testing.T) { | ||
| os.Unsetenv(readUNCPathEnv) |
loader/loader.go
Outdated
| @@ -29,6 +29,8 @@ import ( | |||
| "github.com/open-policy-agent/opa/util" | |||
| ) | |||
|
|
|||
| const readUNCPathEnv = "READ_UNC_PATH" | |||
There was a problem hiding this comment.
I'm not a huge fan of shadow config via env vars 😅 But if we have to do it, let's prefix this with OPA_
ashutosh-narkar
force-pushed
the
handle-unc-path
branch
from
0039f28
to
ebca544
Compare
srenatus
previously approved these changes
Aug 16, 2024
loader/loader.go
Outdated
|
|
||
| func checkForUNCPath(path string) error { | ||
| if isUNC(path) { | ||
| return fmt.Errorf("UNC path read is not allowed") |
There was a problem hiding this comment.
[nit] errors.New("...") or fmt.Errorf("UNC path read is not allowed: %s", path)
If a UNC path is provided to OPA it won't read it and instead return an error. This applies to paths to load bundles and individual data/policy files. One reason behind blocking UNC paths is they could trigger a NTLMv2 hash leak. For example, if a SMB share is provided, OPA will attempt to open it triggering LLMNR queries which contain the client's NTLMv2 hash which can be cracked using some tools. This could be exploited by a malicious user. Signed-off-by: Ashutosh Narkar <[email protected]>
ashutosh-narkar
force-pushed
the
handle-unc-path
branch
from
ebca544
to
e672ba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a UNC path is provided to OPA it won't read it
and instead return an error. This applies to paths
to load bundles and individual data/policy files.
One reason behind blocking UNC paths is they could
trigger a NTLMv2 hash leak. For example, if a SMB share
is provided, OPA will attempt to open it triggering LLMNR
queries which contain the client's NTLMv2 hash which can be cracked
using some tools. This could be exploited by a malicious user.