cmd/exec: remove "pretty" format #6923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never supported, and the flag is thus confusing. Since the only supported format is "json" (the default), the flag is redundant now. However, I've kept it so if someone uses `opa exec --format=json` somewhere, their calls won't become invalid. If someone had been using `opa exec --format=pretty`, they will now see an error, but I think that's less confusing: pretty formatting is just not supported for 'opa exec'. Signed-off-by: Stephan Renatus <[email protected]>
anderseknert
approved these changes
Aug 13, 2024
|
A change log entry would be helpful to make sure we point this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never supported, and the flag is thus confusing. Since the only supported format is "json" (the default), the flag is redundant now. However, I've kept it so if someone uses
opa exec --format=jsonsomewhere, their calls won't become invalid.If someone had been using
opa exec --format=pretty, they will now see an error, but I think that's less confusing: pretty formatting is just not supported for 'opa exec'.