Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update envoy-tutorial-istio.md #6896

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Pindar
Copy link
Contributor

@Pindar Pindar commented Jul 29, 2024

Correct typ of port in the MeshConfig for extensionProviders

Why the changes in this PR are needed?

The current state doesn’t work. The change reflects the Typ specified by the documentation:

https://istio.io/latest/docs/reference/config/istio.mesh.v1alpha1/#MeshConfig-ExtensionProvider-EnvoyExternalAuthorizationGrpcProvider

What are the changes in this PR?

Change Typ string to int

Notes to assist PR review:

Further comments:

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 17b6cc9
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/66acf8fa99d70c000804229b
😎 Deploy Preview https://deploy-preview-6896--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Pindar. Have you verified if the tutorial works as expected with this change? If yes, can also please update https://github.com/open-policy-agent/opa-envoy-plugin/blob/main/examples/istio/quick_start.yaml#L9.

@ashutosh-narkar
Copy link
Member

@Pindar please let us know once you've verified that the tutorial works as expected with your changes and we can get this in. Thanks.

@Pindar
Copy link
Contributor Author

Pindar commented Aug 1, 2024

Hi @ashutosh-narkar - I can say with certainty that this works with AKS. I was testing a specific scenario: Azure/AKS#3792 (comment)

I now added another passage, because it took me hours to find out that the service cannot be found without a namespace in certain cases. A note in the tutorial will hopefully help others.

@ashutosh-narkar
Copy link
Member

@Pindar can you please squash and sign-off your commit and we can get this in. Thanks!

@Pindar Pindar force-pushed the patch-1 branch 3 times, most recently from a3473c9 to 7c2fd06 Compare August 2, 2024 06:55
@Pindar
Copy link
Contributor Author

Pindar commented Aug 2, 2024

@ashutosh-narkar done.

Correct typ of port in the MeshConfig for extensionProviders and add section about Meshconfig's service value

Signed-off-by: Pindar <[email protected]>
@ashutosh-narkar ashutosh-narkar merged commit db0a80b into open-policy-agent:main Aug 2, 2024
28 checks passed
@Pindar Pindar deleted the patch-1 branch August 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants