Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6769 #6773

Conversation

eubaranov
Copy link
Contributor

@eubaranov eubaranov commented May 30, 2024

Why the changes in this PR are needed?

Fixes: #6769

What are the changes in this PR?

Shared struct field map modifications were replaced with method local map modification

Notes to assist PR review:

Further comments:

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for working on this. I would ask for a test, but this was spurious before, right? So it's probably not easy to test. Anyways, the concurrent map access should be resolved from looking at the code ✔️

Thanks again!

@eubaranov
Copy link
Contributor Author

but this was spurious before, right?

yep

Anyways, the concurrent map access should be resolved from looking at the code

yes, the fix is trivial

@eubaranov eubaranov force-pushed the fix/oauth2clientcredentialscuthplugin-concurrent-map-writes branch from dd725f5 to d6300b5 Compare May 30, 2024 14:18
Copy link

netlify bot commented May 30, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit d6300b5
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/66588ab0a281d0000899f60d
😎 Deploy Preview https://deploy-preview-6773--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit d771138
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/6658acc9cb91450008812cdf
😎 Deploy Preview https://deploy-preview-6773--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashutosh-narkar ashutosh-narkar force-pushed the fix/oauth2clientcredentialscuthplugin-concurrent-map-writes branch from 45a1364 to d771138 Compare May 30, 2024 16:43
@ashutosh-narkar ashutosh-narkar merged commit f2ffbd6 into open-policy-agent:main May 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth2ClientCredentialsAuthPlugin: fatal error: concurrent map writes
3 participants