Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: requestToken close response body #6708

Conversation

johanneslarsson
Copy link
Contributor

@johanneslarsson johanneslarsson commented Apr 23, 2024

Why the changes in this PR are needed?

We are currently leaking sockets. These are open unclosed sockets from 7 days ago

ls -l /proc/1/fd/*|grep socket
lrwx------    1 core     core            64 Apr 16 13:00 /proc/1/fd/3 -> socket:[22595818]
lrwx------    1 core     core            64 Apr 16 13:00 /proc/1/fd/7 -> socket:[94892]
lrwx------    1 core     core            64 Apr 16 13:00 /proc/1/fd/8 -> socket:[22592372]
lrwx------    1 core     core            64 Apr 16 13:00 /proc/1/fd/9 -> socket:[22589424]

What are the changes in this PR?

Close the response body after requesting a token

@johanneslarsson johanneslarsson force-pushed the fix/add-auth-close-response-body branch from c41b2a9 to fc83e6c Compare April 23, 2024 09:46
@ashutosh-narkar ashutosh-narkar force-pushed the fix/add-auth-close-response-body branch from fc83e6c to 8d62a72 Compare April 23, 2024 20:07
@ashutosh-narkar ashutosh-narkar merged commit ef8532f into open-policy-agent:main Apr 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants