Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v0.59.0 release #6447

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

johanfylling
Copy link
Contributor

No description provided.

Signed-off-by: Johan Fylling <[email protected]>
Signed-off-by: Johan Fylling <[email protected]>
Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 2907775
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/65689fc0e0c1a600082c4945
😎 Deploy Preview https://deploy-preview-6447--openpolicyagent.netlify.app/docs/edge
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This release adds tooling to help prepare existing policies for the upcoming OPA 1.0 release.
This release also contains a mix of improvements, bugfixes and security fixes for third-party libraries.

### Rego v1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this section. Is this the time to inform the community about this, or should we wait until opa fmt also attempts to fix deprecated built-in calls?

We need get this out there sometime, though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as long as we're clear that "the future release" is not this one, and we add some words such that this is unmistakably clear, it's good to get this out. 👍

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

CHANGELOG.md Outdated
## 0.59.0

This release adds tooling to help prepare existing policies for the upcoming OPA 1.0 release.
This release also contains a mix of improvements, bugfixes and security fixes for third-party libraries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This release also contains a mix of improvements, bugfixes and security fixes for third-party libraries.
It also contains a mix of improvements, bugfixes and security fixes for third-party libraries.

This release adds tooling to help prepare existing policies for the upcoming OPA 1.0 release.
This release also contains a mix of improvements, bugfixes and security fixes for third-party libraries.

### Rego v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as long as we're clear that "the future release" is not this one, and we add some words such that this is unmistakably clear, it's good to get this out. 👍

### Runtime, Tooling, SDK

- ast: Adding `rule_head_refs` capabilities feature flag ([#6334](https://github.com/open-policy-agent/opa/issues/6334)) authored by @johanfylling
- build: Remove rootless image variant ([#4295](https://github.com/open-policy-agent/opa/issues/4295)) authored by @ashutosh-narkar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important to call out once more, isn't it? 🤔

CHANGELOG.md Outdated
Comment on lines 85 to 87
- go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp from 0.45.0 to 0.46.1
- go.opentelemetry.io/otel/exporters/otlp/otlptrace from 1.19.0 to 1.21.0
- go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from 1.19.0 to 1.21.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's combine these, sayng "OpenTelemetry (contrib) 1.21.0/0.46.1"

CHANGELOG.md Outdated
- docs: Disk storage broken link ([#6425](https://github.com/open-policy-agent/opa/pull/6425)) authored by @francoisauclair911
- docs: Update istio envoy tutorial to use AuthorizationPolicy ([#6426](https://github.com/open-policy-agent/opa/pull/6426)) authored by @tjons
- Dependency updates; notably:
- golang: Update golang to 1.21.4 (authored by @ashutosh-narkar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only this one and the OTel version is notable, here. What do you think? Would you care much about the rest of the bumps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're probably right. Looking back at earlier release notes, this fluctuates a bit from time to time.

CHANGELOG.md Outdated
Formatted modules are compatible with both the current version of OPA and 1.0.
Modules using deprecated built-ins will terminate formatting with an error. Future versions of OPA will support rewriting applicable calls with equivalent Rego compatible with 1.0.

When used with `opa check`, the `--rego-v1` flag will check that the modules are compatibility with both the current version of OPA and 1.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When used with `opa check`, the `--rego-v1` flag will check that the modules are compatibility with both the current version of OPA and 1.0.
When used with `opa check`, the `--rego-v1` flag will check that the modules are compatible with both the current version of OPA and 1.0.

[typo]

Copy link
Contributor

@philipaconrad philipaconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanfylling This looks good! Thanks for working in the suggested edits. 🙂

@johanfylling johanfylling merged commit c8e7863 into open-policy-agent:main Nov 30, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants