Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Annotations with new Rego subheading and example #5180

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

Parsifal-M
Copy link
Contributor

Added Rego subheading to the annotations documentation section and added an example of using annotations, then below that a link to the Rego policy reference.

This is for #4937

Signed-off-by: Peter Macdonald [email protected]

@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 9ce1114
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/6331573eecdd7d0009cbc04c
😎 Deploy Preview https://deploy-preview-5180--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/content/annotations.md Show resolved Hide resolved
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also link to the other section as mentioned in the issue, perhaps?

@Parsifal-M
Copy link
Contributor Author

Let's also link to the other section as mentioned in the issue, perhaps?

Is that not If you'd like more examples and information on this, you can see more here under the [Rego](../policy-reference/#rego) policy reference. Unless I misunderstood the link @anderseknert mentions is https://www.openpolicyagent.org/docs/latest/policy-reference/#rego

Please let me know? Thanks!

srenatus
srenatus previously approved these changes Sep 26, 2022
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Sorry my bad. LGTM

…nd a link to the policy reference

Signed-off-by: Peter Macdonald <[email protected]>

added a newline as requested

Signed-off-by: Peter Macdonald <[email protected]>
@Parsifal-M
Copy link
Contributor Author

Hey @srenatus

No worries, did not mean to "dismiss" your review, I did add the new line, think I need to resolve the conversation before I push again sorry for that 😅

Thanks!

@srenatus srenatus merged commit 2df5c19 into open-policy-agent:main Sep 26, 2022
@srenatus
Copy link
Contributor

No worries, github does that because it's configured to do it. This isn't on you 😉 Thanks for contributing! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants