-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Annotations with new Rego subheading and example #5180
Conversation
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also link to the other section as mentioned in the issue, perhaps?
Is that not Please let me know? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course. Sorry my bad. LGTM
…nd a link to the policy reference Signed-off-by: Peter Macdonald <[email protected]> added a newline as requested Signed-off-by: Peter Macdonald <[email protected]>
6538af3
to
9ce1114
Compare
Hey @srenatus No worries, did not mean to "dismiss" your review, I did add the new line, think I need to resolve the conversation before I push again sorry for that 😅 Thanks! |
No worries, github does that because it's configured to do it. This isn't on you 😉 Thanks for contributing! 🥳 |
Added Rego subheading to the annotations documentation section and added an example of using annotations, then below that a link to the Rego policy reference.
This is for #4937
Signed-off-by: Peter Macdonald [email protected]