topdown/buitins: io.jwt.encode_sign uses BuiltinContext random source #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/builtins/ecdsa-should-use-our-rand
branch
from
590c7c6
to
48d9d01
Compare
Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/builtins/ecdsa-should-use-our-rand
branch
from
48d9d01
to
033feae
Compare
tsandall
approved these changes
Aug 18, 2021
jgchn
pushed a commit
to jgchn/opa
that referenced
this pull request
Aug 20, 2021
…open-policy-agent#3738) It didn't before, so we had not much control over the entropy that is getting into the signature for ecdsa. This is useful if you want reproducible outcomes over multiple policy evaluations, such as in testing. Signed-off-by: Stephan Renatus <[email protected]>
dolevf
pushed a commit
to dolevf/opa
that referenced
this pull request
Nov 4, 2021
…open-policy-agent#3738) It didn't before, so we had not much control over the entropy that is getting into the signature for ecdsa. This is useful if you want reproducible outcomes over multiple policy evaluations, such as in testing. Signed-off-by: Stephan Renatus <[email protected]> Signed-off-by: Dolev Farhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It didn't before, so we had not much control over the entropy that is getting into the signature for ecdsa.
This is useful if you want reproducible outcomes over multiple policy evaluations, such as in testing.