Authentication option doesn't take effect if there's no authorization policy #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kale-amruta
force-pushed
the
amruta-basicAuth-3380
branch
2 times, most recently
from
d8e152b
to
4f1b438
Compare
kale-amruta
force-pushed
the
amruta-basicAuth-3380
branch
from
44398fe
to
a26ea96
Compare
anderseknert
previously approved these changes
Apr 19, 2021
There was a problem hiding this comment.
LGTM. You'll need to squash the commits before merge though. Thanks @kale-amruta!
This commit gives a message stating authetication will be ineffective when you run the opa server with authentication as TOKEN and no authorization Fixes open-policy-agent#3380 Signed-off-by: Amruta Kale <[email protected]>
kale-amruta
force-pushed
the
amruta-basicAuth-3380
branch
from
51a0851
to
82cb075
Compare
anderseknert
approved these changes
Apr 19, 2021
|
@anderseknert Thanks! I dont think I have access to merge the PR. Will you be merging it? |
|
It looks good from my POV, but never hurts to get a second opinion before merge so leaving this for someone else to review. |
|
@anderseknert sure, makes sense. |
| @@ -305,6 +305,10 @@ func (rt *Runtime) Serve(ctx context.Context) error { | |||
| "diagnostic-addrs": *rt.Params.DiagnosticAddrs, | |||
| }).Info("Initializing server.") | |||
|
|
|||
| if rt.Params.Authorization == server.AuthorizationOff && rt.Params.Authentication == server.AuthenticationToken { | |||
| logrus.Error("Token authentication enabled without authorization. Authentication will be ineffective. See https://www.openpolicyagent.org/docs/latest/security/#authentication-and-authorization for more information.") | |||
There was a problem hiding this comment.
Nit: Should we log a warning (ie. logrus.Warn) ?
There was a problem hiding this comment.
Better check the resolved conversations ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix gives a Error msg when you start the opa runtime server with authentication as TOKEN and authorization OFF
Fixes #3380