topdown: Add urlquery.decode_object builtin #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builtin is the reverse of the encode_object builtin and makes it easier to use the URI query parameters in policies Fixes open-policy-agent#2647 Signed-off-by: Frederic <[email protected]>
GBrawl
commented
Aug 30, 2020
| return err | ||
| } | ||
|
|
||
| queryParams, err := url.ParseQuery(string(query)) |
There was a problem hiding this comment.
I'm using ParseQuery here, but if it is better to also include the "?" in the query string we could use https://golang.org/pkg/net/url/#URL.Query instead
tsandall
approved these changes
Aug 31, 2020
| return err | ||
| } | ||
|
|
||
| queryParams, err := url.ParseQuery(string(query)) |
|
Thanks for contributing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builtin is the reverse of the encode_object builtin and
makes it easier to use the URI query parameters in policies
Fixes #2647
Signed-off-by: Frederic [email protected]