-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/content: add terraform module example to tutorial #2411
docs/content: add terraform module example to tutorial #2411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @princespaghetti !! Just a few minor things to fixup and maybe some re-arranging of the headers/sections and we'll be in good shape.
At a high level I'm wondering if maybe we should split this up from the other tutorial. Have like a h1 "Getting Started" chunk that is sections 1-6 as they exist today, plus the "Wrap Up" section. Then have another top level h1 after that for this example showing how to deal with modules. Maybe in the "Wrap Up" mention to continue below for that use-case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Go ahead and squash the commits
just did it with a rebase, any way to do it without a force push? |
I don't think so, I always just force push. If you use |
should be all set @patrick-east! |
Fixes: #1772 Signed-off-by: Anthony Barbieri <[email protected]>
Fixes: #1772
Signed-off-by: Anthony Barbieri [email protected]