Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/content: add terraform module example to tutorial #2411

Merged
merged 1 commit into from
May 21, 2020
Merged

docs/content: add terraform module example to tutorial #2411

merged 1 commit into from
May 21, 2020

Conversation

princespaghetti
Copy link
Contributor

Fixes: #1772
Signed-off-by: Anthony Barbieri [email protected]

Copy link
Contributor

@patrick-east patrick-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @princespaghetti !! Just a few minor things to fixup and maybe some re-arranging of the headers/sections and we'll be in good shape.

At a high level I'm wondering if maybe we should split this up from the other tutorial. Have like a h1 "Getting Started" chunk that is sections 1-6 as they exist today, plus the "Wrap Up" section. Then have another top level h1 after that for this example showing how to deal with modules. Maybe in the "Wrap Up" mention to continue below for that use-case.

docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
docs/content/terraform.md Outdated Show resolved Hide resolved
patrick-east
patrick-east previously approved these changes May 20, 2020
Copy link
Contributor

@patrick-east patrick-east left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Go ahead and squash the commits

@princespaghetti
Copy link
Contributor Author

just did it with a rebase, any way to do it without a force push?

@patrick-east
Copy link
Contributor

just did it with a rebase, any way to do it without a force push?

I don't think so, I always just force push. If you use --force-with-lease its arguably more safe, but hey, thats what the reflog is for 😆

@princespaghetti
Copy link
Contributor Author

should be all set @patrick-east!

@patrick-east patrick-east merged commit 02ed718 into open-policy-agent:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Update Terraform guide to show nested child_modules
2 participants