plugins: Add support to specify bearer token path #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the bearer token config to allow clients to specify a path to the token. With this refreshing tokens becomes easier as OPA will now reload the token from file. Fixes open-policy-agent#2241 Signed-off-by: Ashutosh Narkar <[email protected]>
|
I notice the docs don't say anything about OPA picking up changes to these
files. I'm guessing this will be a common request so it would be nice to
include a note (either in the Bearer and TLS configuration docs or
elsewhere on the configuration page.)
…On Fri, Apr 10, 2020 at 8:29 PM Ashutosh Narkar ***@***.***> wrote:
Merged #2287 <#2287> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2287 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB2KJPI6EL4GKUAFX47A2TRL62XNANCNFSM4MFX74VQ>
.
--
-Torin
|
Not sure I follow, the new option is documented in https://github.com/open-policy-agent/opa/pull/2287/files#diff-c23c3ea53dad0a10f0aa0544ef005e5d --> https://www.openpolicyagent.org/docs/edge/configuration/#bearer-token Did you have something else in mind, an example config or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the bearer token config to allow clients to specify
a path to the token. With this refreshing tokens becomes easier as OPA
will now reload the token from file.
Fixes #2241
Signed-off-by: Ashutosh Narkar [email protected]