Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision logging: confusing "upload chunk size too small" error message #5155

Closed
anderseknert opened this issue Sep 19, 2022 · 1 comment · Fixed by #5156
Closed

Decision logging: confusing "upload chunk size too small" error message #5155

anderseknert opened this issue Sep 19, 2022 · 1 comment · Fixed by #5156
Labels

Comments

@anderseknert
Copy link
Member

When the size of a decision log chunk exceeds the size limit set by the upload_size_limit_bytes configuration attribute, an error message saying "upload chunk size too small" is printed to the logs. This is confusing to users, as arguably, the upload chunk size is too big, and the configured value is too small. Additionally, there's no indication as to what configuration attribute controls this, so it's not immediately clear what to do in order to fix this. A better error message could say something like:

"upload chunk size (81293) exceeds upload_size_limit_bytes (64000)"

@philipaconrad
Copy link
Contributor

I like the updated error message! That gives the user more context, and makes the problem a bit clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants