Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wildcard mangling not applied to args in rule head #480

Closed
tsandall opened this issue Oct 13, 2017 · 0 comments
Closed

Wildcard mangling not applied to args in rule head #480

tsandall opened this issue Oct 13, 2017 · 0 comments
Labels
bug

Comments

@tsandall
Copy link
Member

The parser is not mangling wildcard vars found in the new args part of the rule head. Since the AST walker calls the visitor on terms, it should be possible to simplify the wildcard mangling visitor and prevent this type of bug from popping up in the future.
tsandall added a commit to tsandall/opa that referenced this issue Oct 13, 2017
@tsandall
Fix wildcard mangling in rule head
d863e72 
Now that the AST walker can visit terms (as well as values) it's better
to just walk all terms in the statement and mangle them (rather than
relying on speical handling for collections of terms, which is bound to
break over time.)

Fixes open-policy-agent#480
@tsandall tsandall mentioned this issue Oct 13, 2017
Merged
@tsandall tsandall added the bug label Oct 13, 2017
tsandall added a commit that referenced this issue Oct 13, 2017
@tsandall
Fix wildcard mangling in rule head
3091c26 
Now that the AST walker can visit terms (as well as values) it's better
to just walk all terms in the statement and mangle them (rather than
relying on speical handling for collections of terms, which is bound to
break over time.)

Fixes #480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsandall