Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve decision logger to support plugins concurrently with console and HTTP logging #4013

Closed
tsandall opened this issue Nov 15, 2021 · 0 comments · Fixed by #4039
Closed

Improve decision logger to support plugins concurrently with console and HTTP logging #4013

tsandall opened this issue Nov 15, 2021 · 0 comments · Fixed by #4039
Assignees
@srenatus

Comments

@tsandall
Copy link
Member

tsandall commented Nov 15, 2021 •
edited
Loading

Currently, the decision log plugin supports three modes:

  1. Console logging
  2. Async HTTP logging
  3. Custom plugins

(1) and (2) can be used together and so can (1) and (3) but (2) and (3) cannot. We should update the decision logger so that (2) and (3) are not mutually exclusive.
@srenatus srenatus mentioned this issue Nov 18, 2021
Merged
@srenatus srenatus self-assigned this Nov 18, 2021
srenatus added a commit to srenatus/opa that referenced this issue Nov 19, 2021
@srenatus
plugins/logs: allow for using service AND custom plugin
0d0e81a 
Now any subset of service, plugin, console logger should be usable.

Fixes open-policy-agent#4013.

Signed-off-by: Stephan Renatus <[email protected]>
srenatus added a commit that referenced this issue Nov 19, 2021
@srenatus
plugins/logs: allow for using service AND custom plugin (#4039)
2b7df1c 
Now any subset of service, plugin, console logger should be usable.

Fixes #4013.

Signed-off-by: Stephan Renatus <[email protected]>
floriangasc pushed a commit to floriangasc/opa that referenced this issue Nov 22, 2021
@srenatus @floriangasc
plugins/logs: allow for using service AND custom plugin (open-policy-…
91168b0 
…agent#4039)

Now any subset of service, plugin, console logger should be usable.

Fixes open-policy-agent#4013.

Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srenatus srenatus

Labels
None yet
Projects
Open Policy Agent
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

plugins/logs: allow for using service AND custom plugin srenatus/opa
2 participants
@tsandall @srenatus