-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Kubernetes policy primer example is missing output box #2177
Comments
Thanks @rleekin that is indeed an error. It looks like it should be showing the output of the "live doc" snippets above, the GitHub markdown renderer shows it a little different (although still broken) https://github.com/open-policy-agent/opa/blob/master/docs/content/kubernetes-primer.md#deny-rules In the source code it has https://github.com/open-policy-agent/opa/blame/master/docs/content/kubernetes-primer.md#L83-L88 (linking to blame since all the nicer views hide the markdown 😢 ) Where the So.. I think what we need to do is add the ``` to close the |
okay, I'll work on fixing this, please assign me to this. Thanks Patrick! |
This commit adds a backtick to the live code block to fix formatting issues in the documentation. This addresses the examples in the *kubernetes-primer.md* document. The current document does not render the live code block. Fixes open-policy-agent#2177 Signed-off-by: Rachel Leekin <[email protected]>
This commit adds a backtick to the live code block to fix formatting issues in the documentation. This addresses the examples in the *kubernetes-primer.md* document. The current document does not render the live code block. Fixes #2177 Signed-off-by: Rachel Leekin <[email protected]>
in the documentation, under the Policy Primer via Examples section, in the Deny Rules section. The last sentence of that section ends without an image or answer.
"When the deny rule is evaluated with the input above, the answer is:"
I think this is an error and I would be happy to fix it if you tell me what should be there. Thanks
The text was updated successfully, but these errors were encountered: