You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A dev should be able to run the unit tests and any of the checks for formatting/vetting offline with just the go tools locally installed and the source code.
Actual Behavior
Builds fail sometimes because they are reaching out to hit package servers (ie git repos) due to our usage of go modules.
We can maybe allow the default to reach out to the internet, but really none of the package versions should change.. and everything is vendored. There isn't a good reason for it to need to do anything.
I'd be reasonably ok if we even just had a like OFFLINE env var or something to allow for it.
The text was updated successfully, but these errors were encountered:
There are a handful of scripts that were making `go run` calls without
the required environment vars setup force go to use modules and only
use the vendor directory.
For golang 1.11/12 if OPA was in a path outside of the GOPATH it would
switch into module mode automatically (by default) and then try to
fetch packages and stuff remotely rather than use the vendor dir.
For golang 1.13+ any directory for OPA would (by default) result in
trying to use the remote modules rather than vendor dir.
Fixes: open-policy-agent#2063
Signed-off-by: Patrick East <[email protected]>
There are a handful of scripts that were making `go run` calls without
the required environment vars setup force go to use modules and only
use the vendor directory.
For golang 1.11/12 if OPA was in a path outside of the GOPATH it would
switch into module mode automatically (by default) and then try to
fetch packages and stuff remotely rather than use the vendor dir.
For golang 1.13+ any directory for OPA would (by default) result in
trying to use the remote modules rather than vendor dir.
Fixes: #2063
Signed-off-by: Patrick East <[email protected]>
Expected Behavior
A dev should be able to run the unit tests and any of the checks for formatting/vetting offline with just the go tools locally installed and the source code.
Actual Behavior
Builds fail sometimes because they are reaching out to hit package servers (ie git repos) due to our usage of go modules.
Ex from a Travis failure:
Steps to Reproduce the Problem
make check test
Additional Info
We can maybe allow the default to reach out to the internet, but really none of the package versions should change.. and everything is vendored. There isn't a good reason for it to need to do anything.
I'd be reasonably ok if we even just had a like
OFFLINE
env var or something to allow for it.The text was updated successfully, but these errors were encountered: