Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacror grammar: rename expr to literal-expr and expr2 to expr #93

Merged
merged 1 commit into from
Jan 26, 2021
Merged

refacror grammar: rename expr to literal-expr and expr2 to expr #93

merged 1 commit into from
Jan 26, 2021

Conversation

vgramer
Copy link
Member

@vgramer vgramer commented Jan 22, 2021 •
edited
Loading

Description

expr2 rule is an explicit name (i really wasn't inspired when I wrote it :/ )

This pr rename the grammar rule

grammar: rename rules:
- `expr` to `literal-expr`
- `expr2` to `expr`

if you have a better name in mind, I am open to suggestions.

Special notes for your reviewer

@vgramer vgramer self-assigned this Jan 22, 2021
@vgramer vgramer added the bug Something isn't working label Jan 22, 2021
@vgramer vgramer force-pushed the refacto_grammar_expr2 branch from dea6eb8 to dd64dd9 Compare January 25, 2021 20:58
@vgramer vgramer force-pushed the fix_grammar_factor_expr branch from 9474e48 to d786a10 Compare January 26, 2021 12:59
@vgramer vgramer force-pushed the refacto_grammar_expr2 branch from dd64dd9 to 1f97b51 Compare January 26, 2021 12:59
Base automatically changed from fix_grammar_factor_expr to master January 26, 2021 18:17
@vgramer vgramer force-pushed the refacto_grammar_expr2 branch from 1f97b51 to a08e834 Compare January 26, 2021 18:19
@vgramer vgramer marked this pull request as ready for review January 26, 2021 18:20
asadali
asadali approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@asadali asadali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

literal-expr seems to fit for now. 👍

@vgramer vgramer merged commit 04cf68a into master Jan 26, 2021
@vgramer
Copy link
Member Author

vgramer commented Jan 26, 2021

thanks again for the review

@vgramer vgramer deleted the refacto_grammar_expr2 branch January 26, 2021 18:37
@vgramer vgramer added kind/refactoring Categorizes issue or PR as related to cleaning up code, process, or technical debt area/grammar issue or pr related to the grammar and removed bug Something isn't working labels Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asadali asadali asadali approved these changes

@anderseknert anderseknert Awaiting requested review from anderseknert

Assignees

@vgramer vgramer

Labels
area/grammar issue or pr related to the grammar kind/refactoring Categorizes issue or PR as related to cleaning up code, process, or technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgramer @asadali