Fix quay manifest cache issue

[sozercan]

Signed-off-by: Sertac Ozercan [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #665

Special notes for your reviewer:

[xunholy]

This isn't the issue and also defeats the purpose of a multi-arch image where we don't want to re-tag them rather we want an image that is already multi-arch.

This should remain being

	DOCKER_CLI_EXPERIMENTAL=enabled docker buildx build --platform "linux/amd64,linux/arm64,linux/arm/v7" \
		-t $(REPOSITORY):$(DEV_TAG) \
		. --push

[sozercan]

This is a workaround for the Quay issue. We can not push same tag to Quay twice using buildx, which will be required for release (pushing latest + version).

Open to suggestions for another fix or workaround

[xunholy]

I didn't see this in my previous PR until now, we don't need both these to be pushed

	DOCKER_CLI_EXPERIMENTAL=enabled docker manifest push $(REPOSITORY):$(DEV_TAG)
	DOCKER_CLI_EXPERIMENTAL=enabled docker manifest push $(REPOSITORY):dev

Makefile L7 DEV_TAG ?= dev which means you're effectively just pushing the same tag twice.

[sozercan]

It's not pushing the same tag twice. If you look at the comment above L7, DEV_TAG gets overriden by 7-digit SHA. It's pushing SHA tag + dev tag (so it's easier to grab the latest dev tag)

[xunholy]

The main issue we needed to resolve was the pushing tags, we didn't need to break the architectures into multiple tags because that wasn't the issue.

The issue was we had two tags we were trying to push in the same --push cmd

[sozercan]

Closing this per discussion in the community call last week, will open a PR to migrate to Docker Hub