ci: push container images to ghcr.io as well #3658
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dulltz
force-pushed
the
feature/release-to-ghcr
branch
2 times, most recently
from
d13fc9d
to
8a082f4
Compare
dulltz
force-pushed
the
feature/release-to-ghcr
branch
2 times, most recently
from
f29dedb
to
6148782
Compare
Signed-off-by: TakahiroTsuruda <[email protected]>
dulltz
force-pushed
the
feature/release-to-ghcr
branch
from
6148782
to
0804e02
Compare
sozercan
reviewed
Oct 24, 2024
.github/workflows/release.yaml
Outdated
| - name: Build and push ghcr.io/${{ env.IMAGE_REPO }} | ||
| if: steps.check-ghcr-image.outputs.exists == 'false' | ||
| run: | | ||
| make REPOSITORY=ghcr.io/${{ env.IMAGE_REPO }} docker-buildx-release \ |
There was a problem hiding this comment.
can you integrate this into the existing release and pre-release flows so artifacts don't get rebuild and digests will be same
There was a problem hiding this comment.
Got it, I'll give it a try and update the PR.
Signed-off-by: TakahiroTsuruda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add GHCR as a destination container registry.
With this change we will be able to pull the container at the following URI:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3652
Special notes for your reviewer:
After merging this PR, container images will appear in Packages section.